Re: [PATCH v5] fpga manager: Add Altera CvP driver

2017-06-08 Thread Anatolij Gustschin
On Thu, 8 Jun 2017 17:44:19 +0300 Andy Shevchenko andy.shevche...@gmail.com wrote: >On Thu, Jun 8, 2017 at 5:15 PM, Anatolij Gustschin wrote: >> On Thu, 8 Jun 2017 02:38:55 +0300 >> Andy Shevchenko andy.shevche...@gmail.com wrote: >>>On Thu, Jun 8, 2017 at 2:09 AM, Anatolij Gustschin wrote:

Re: [PATCH v5] fpga manager: Add Altera CvP driver

2017-06-08 Thread Andy Shevchenko
On Thu, Jun 8, 2017 at 5:15 PM, Anatolij Gustschin wrote: > On Thu, 8 Jun 2017 02:38:55 +0300 > Andy Shevchenko andy.shevche...@gmail.com wrote: >>On Thu, Jun 8, 2017 at 2:09 AM, Anatolij Gustschin wrote: >>> On Fri, 2 Jun 2017 20:43:21 +0300 >>> Andy Shevchenko andy.shevche...@gmail.com wrote:

Re: [PATCH v5] fpga manager: Add Altera CvP driver

2017-06-08 Thread Anatolij Gustschin
On Thu, 8 Jun 2017 02:38:55 +0300 Andy Shevchenko andy.shevche...@gmail.com wrote: >On Thu, Jun 8, 2017 at 2:09 AM, Anatolij Gustschin wrote: >> On Fri, 2 Jun 2017 20:43:21 +0300 >> Andy Shevchenko andy.shevche...@gmail.com wrote: > >Besides below comments, please, do > >s/VSEC_/VSE_/g > >for e

Re: [PATCH v5] fpga manager: Add Altera CvP driver

2017-06-07 Thread Andy Shevchenko
On Sun, May 14, 2017 at 10:01 PM, kbuild test robot wrote: > Hi Anatolij, > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.12-rc1 next-20170512] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://

Re: [PATCH v5] fpga manager: Add Altera CvP driver

2017-06-07 Thread Andy Shevchenko
On Thu, Jun 8, 2017 at 2:09 AM, Anatolij Gustschin wrote: > On Fri, 2 Jun 2017 20:43:21 +0300 > Andy Shevchenko andy.shevche...@gmail.com wrote: Besides below comments, please, do s/VSEC_/VSE_/g for entire file. We are following PCI and Thunderbolt pattern for use of Vendor Specific Extended C

Re: [PATCH v5] fpga manager: Add Altera CvP driver

2017-06-07 Thread Anatolij Gustschin
On Fri, 2 Jun 2017 20:43:21 +0300 Andy Shevchenko andy.shevche...@gmail.com wrote: ... > >> + void(*write_data)(struct altera_cvp_conf *conf, >> + u32 val); > >Is it too far beyond 80 characters? I would leave it in one line (~83

Re: [PATCH v5] fpga manager: Add Altera CvP driver

2017-06-02 Thread Andy Shevchenko
On Fri, Jun 2, 2017 at 8:43 PM, Andy Shevchenko wrote: > On Sun, May 14, 2017 at 6:51 PM, Anatolij Gustschin wrote: >> Add FPGA manager driver for loading Arria-V/Cyclone-V/Stratix-V >> and Arria-10 FPGAs via CvP. > > Few comments from me. After addressing them, FWIW, Reviewed-by: Andy Shevchenk

Re: [PATCH v5] fpga manager: Add Altera CvP driver

2017-06-02 Thread Andy Shevchenko
On Sun, May 14, 2017 at 6:51 PM, Anatolij Gustschin wrote: > Add FPGA manager driver for loading Arria-V/Cyclone-V/Stratix-V > and Arria-10 FPGAs via CvP. Few comments from me. > +struct altera_cvp_conf { > + struct fpga_manager *mgr; > + struct pci_dev *pci_dev; > +

Re: [PATCH v5] fpga manager: Add Altera CvP driver

2017-06-02 Thread Anatolij Gustschin
Hi Alan, On Sun, 14 May 2017 17:51:22 +0200 Anatolij Gustschin ag...@denx.de wrote: >Add FPGA manager driver for loading Arria-V/Cyclone-V/Stratix-V >and Arria-10 FPGAs via CvP. any comments to this patch? I'll rebase to apply on top of Altera PS-SPI driver series, so that it can be queued for m

Re: [PATCH v5] fpga manager: Add Altera CvP driver

2017-05-14 Thread kbuild test robot
Hi Anatolij, [auto build test ERROR on linus/master] [also build test ERROR on v4.12-rc1 next-20170512] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Anatolij-Gustschin/fpga-manager-Add-Altera-

[PATCH v5] fpga manager: Add Altera CvP driver

2017-05-14 Thread Anatolij Gustschin
Add FPGA manager driver for loading Arria-V/Cyclone-V/Stratix-V and Arria-10 FPGAs via CvP. Signed-off-by: Anatolij Gustschin --- For building this patch requires https://lkml.org/lkml/2017/5/14/73 Changes in v5: - use absolute register offset values - move register bit macros below offset