Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2025-03-13 Thread Matias Ezequiel Vara Larsen
On Thu, Feb 01, 2024 at 07:57:45PM +0100, Harald Mommer wrote: > Hello, > > I thought there would be some more comments coming and I could address > everything in one chunk. Not the case, besides your comments silence. > > On 08.01.24 20:34, Christophe JAILLET wrote: > > > > Hi, > > a few nits b

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2025-03-12 Thread Jason Wang
On Wed, Mar 12, 2025 at 9:36 PM Marc Kleine-Budde wrote: > > On 12.03.2025 14:28:10, Matias Ezequiel Vara Larsen wrote: > > On Wed, Mar 12, 2025 at 11:41:26AM +0100, Marc Kleine-Budde wrote: > > > On 12.03.2025 11:31:12, Matias Ezequiel Vara Larsen wrote: > > > > On Thu, Feb 01, 2024 at 07:57:45PM

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2025-03-12 Thread Matias Ezequiel Vara Larsen
Hello, On Thu, Feb 01, 2024 at 07:57:45PM +0100, Harald Mommer wrote: > Hello, > > I thought there would be some more comments coming and I could address > everything in one chunk. Not the case, besides your comments silence. > > On 08.01.24 20:34, Christophe JAILLET wrote: > > > > Hi, > > a fe

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2025-03-12 Thread Matias Ezequiel Vara Larsen
On Wed, Mar 12, 2025 at 02:36:05PM +0100, Marc Kleine-Budde wrote: > On 12.03.2025 14:28:10, Matias Ezequiel Vara Larsen wrote: > > On Wed, Mar 12, 2025 at 11:41:26AM +0100, Marc Kleine-Budde wrote: > > > On 12.03.2025 11:31:12, Matias Ezequiel Vara Larsen wrote: > > > > On Thu, Feb 01, 2024 at 07:

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2025-03-12 Thread Marc Kleine-Budde
On 12.03.2025 14:28:10, Matias Ezequiel Vara Larsen wrote: > On Wed, Mar 12, 2025 at 11:41:26AM +0100, Marc Kleine-Budde wrote: > > On 12.03.2025 11:31:12, Matias Ezequiel Vara Larsen wrote: > > > On Thu, Feb 01, 2024 at 07:57:45PM +0100, Harald Mommer wrote: > > > > Hello, > > > > > > > > I thoug

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2025-03-12 Thread Matias Ezequiel Vara Larsen
On Wed, Mar 12, 2025 at 11:41:26AM +0100, Marc Kleine-Budde wrote: > On 12.03.2025 11:31:12, Matias Ezequiel Vara Larsen wrote: > > On Thu, Feb 01, 2024 at 07:57:45PM +0100, Harald Mommer wrote: > > > Hello, > > > > > > I thought there would be some more comments coming and I could address > > > e

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2025-03-12 Thread Marc Kleine-Budde
On 12.03.2025 11:31:12, Matias Ezequiel Vara Larsen wrote: > On Thu, Feb 01, 2024 at 07:57:45PM +0100, Harald Mommer wrote: > > Hello, > > > > I thought there would be some more comments coming and I could address > > everything in one chunk. Not the case, besides your comments silence. > > > > O

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2024-02-01 Thread Harald Mommer
Hello, I thought there would be some more comments coming and I could address everything in one chunk. Not the case, besides your comments silence. On 08.01.24 20:34, Christophe JAILLET wrote: Hi, a few nits below, should there be a v6. I'm sure there will be but not so soon. Probably aft

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2024-01-08 Thread Christophe JAILLET
Le 08/01/2024 à 14:10, Mikhail Golubev-Ciuchea a écrit : From: Harald Mommer - CAN Control - "ip link set up can0" starts the virtual CAN controller, - "ip link set up can0" stops the virtual CAN controller - CAN RX Receive CAN frames. CAN frames can be standard or extended, classic

[PATCH v5] can: virtio: Initial virtio CAN driver.

2024-01-08 Thread Mikhail Golubev-Ciuchea
From: Harald Mommer - CAN Control - "ip link set up can0" starts the virtual CAN controller, - "ip link set up can0" stops the virtual CAN controller - CAN RX Receive CAN frames. CAN frames can be standard or extended, classic or CAN FD. Classic CAN RTR frames are supported. - CAN TX