Re: [PATCH v5] arm64: implement ftrace with regs

2019-01-04 Thread Torsten Duwe
On Mon, Dec 17, 2018 at 09:52:04AM +0530, Amit Daniel Kachhap wrote: > There is no error message or crash but no useful output like below, > > /sys/kernel/tracing # echo wake_up_process > set_graph_function > /sys/kernel/tracing # echo function_graph > current_tracer > /sys/kernel/tracing # cat tr

Re: [PATCH v5] arm64: implement ftrace with regs

2018-12-17 Thread Torsten Duwe
On Mon, Dec 17, 2018 at 09:52:04AM +0530, Amit Daniel Kachhap wrote: > There is no error message or crash but no useful output like below, > > /sys/kernel/tracing # echo wake_up_process > set_graph_function > /sys/kernel/tracing # echo function_graph > current_tracer > /sys/kernel/tracing # cat tr

Re: [PATCH v5] arm64: implement ftrace with regs

2018-12-16 Thread Amit Daniel Kachhap
Hi, On Sat, Dec 15, 2018 at 6:14 PM Torsten Duwe wrote: > > On Fri, 14 Dec 2018 21:45:03 +0530 > Amit Daniel Kachhap wrote: > > > Sorry I didn't mention my environment. I am using 4.20-rc3 and it has > > all the above 8 extra patches > > mentioned by you. > > So that should be fine. ok thanks. >

Re: [PATCH v5] arm64: implement ftrace with regs

2018-12-15 Thread Torsten Duwe
On Fri, 14 Dec 2018 21:45:03 +0530 Amit Daniel Kachhap wrote: > Sorry I didn't mention my environment. I am using 4.20-rc3 and it has > all the above 8 extra patches > mentioned by you. So that should be fine. > I read your change description in v3 patchset. You had mentioned there > that graph

Re: [PATCH v5] arm64: implement ftrace with regs

2018-12-14 Thread Amit Daniel Kachhap
Hi, On Fri, Dec 14, 2018 at 3:18 PM Torsten Duwe wrote: > > On Thu, Dec 13, 2018 at 11:01:38PM +0530, Amit Daniel Kachhap wrote: > > On Fri, Nov 30, 2018 at 9:53 PM Torsten Duwe wrote: > > > > Hi Torsten, > > > > I was testing your patch and it seems to work fine for function trace. > > However

Re: [PATCH v5] arm64: implement ftrace with regs

2018-12-14 Thread Torsten Duwe
On Thu, Dec 13, 2018 at 11:01:38PM +0530, Amit Daniel Kachhap wrote: > On Fri, Nov 30, 2018 at 9:53 PM Torsten Duwe wrote: > > Hi Torsten, > > I was testing your patch and it seems to work fine for function trace. However > function graph trace seems broken. Is it work in progress ? or I am > mi

Re: [PATCH v5] arm64: implement ftrace with regs

2018-12-13 Thread Amit Daniel Kachhap
On Fri, Nov 30, 2018 at 9:53 PM Torsten Duwe wrote: > > Use -fpatchable-function-entry (gcc8) to add 2 NOPs at the beginning > of each function. Replace the first NOP thus generated with a quick LR > saver (move it to scratch reg x9), so the 2nd replacement insn, the call > to ftrace, does not clo

[PATCH v5] arm64: implement ftrace with regs

2018-11-30 Thread Torsten Duwe
Use -fpatchable-function-entry (gcc8) to add 2 NOPs at the beginning of each function. Replace the first NOP thus generated with a quick LR saver (move it to scratch reg x9), so the 2nd replacement insn, the call to ftrace, does not clobber the value. Ftrace will then generate the standard stack fr