Re: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW

2018-03-12 Thread Ingo Molnar
* Jason Vas Dias wrote: > Currently the VDSO does not handle NAK, because you have apparently ignored my mails and have again sent patches in violation of established patch sending procedures outlined in process/submitting-patches.rst. Thanks, Ingo

Re: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW

2018-03-12 Thread Jason Vas Dias
The split patches with no checkpatch.pl failures are attached and were just sent in separate emails to the mailing list . Sorry it took a few tries to get right . This will be my last send today - I'm off to use it at work. Thanks & all the best, Jason vdso_vclock_gettime_CLOCK_MONOTONIC_RAW-4

[PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW

2018-03-12 Thread Jason Vas Dias
Currently the VDSO does not handle clock_gettime( CLOCK_MONOTONIC_RAW, &ts ) on Intel / AMD - it calls vdso_fallback_gettime() for this clock, which issues a syscall, having an unacceptably high latency (minimum measurable time or time between measurements) of 300-700ns on 2 2.

Re: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW

2018-03-12 Thread Jason Vas Dias
Good day - On 12/03/2018, Ingo Molnar wrote: > > * Thomas Gleixner wrote: > >> On Mon, 12 Mar 2018, Jason Vas Dias wrote: >> >> checkpatch.pl still reports: >> >>total: 15 errors, 3 warnings, 165 lines checked >> Sorry I didn't see you had responded until 40 mins ago . I finally found wher

Re: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW

2018-03-12 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Mon, Mar 12, 2018 at 08:24:13AM +0100, Ingo Molnar wrote: > > > - Code quality of the submitted patches is atrocious, please run them > > through > >scripts/checkpatch.pl (and make sure they pass) to at least enable the > > reading > >of them. > > I'd s

Re: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW

2018-03-12 Thread Peter Zijlstra
On Mon, Mar 12, 2018 at 08:24:13AM +0100, Ingo Molnar wrote: > - Code quality of the submitted patches is atrocious, please run them through >scripts/checkpatch.pl (and make sure they pass) to at least enable the > reading >of them. I'd suggest also reading: Documentation/CodingStyle

Re: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW

2018-03-12 Thread Ingo Molnar
* Thomas Gleixner wrote: > On Mon, 12 Mar 2018, Jason Vas Dias wrote: > > checkpatch.pl still reports: > >total: 15 errors, 3 warnings, 165 lines checked > > > +notrace static u64 vread_tsc_raw(void) > > +{ > > + u64 tsc, last=gtod->raw_cycle_last; > > + if( likely( gtod->has_rdtscp )

Re: [PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW

2018-03-11 Thread Thomas Gleixner
On Mon, 12 Mar 2018, Jason Vas Dias wrote: checkpatch.pl still reports: total: 15 errors, 3 warnings, 165 lines checked > +notrace static u64 vread_tsc_raw(void) > +{ > + u64 tsc, last=gtod->raw_cycle_last; > + if( likely( gtod->has_rdtscp ) ) > + tsc = rdtscp((void*)0

[PATCH v4.16-rc4 1/2] x86/vdso: on Intel, VDSO should handle CLOCK_MONOTONIC_RAW

2018-03-11 Thread Jason Vas Dias
Currently the VDSO does not handle clock_gettime( CLOCK_MONOTONIC_RAW, &ts ) on Intel / AMD - it calls vdso_fallback_gettime() for this clock, which issues a syscall, having an unacceptably high latency (minimum measurable time or time between measurements) of 300-700ns on 2 2.