Re: [PATCH v4 net-next 1/3] Extended BPF interpreter and converter

2014-03-04 Thread Daniel Borkmann
On 03/04/2014 06:53 PM, Alexei Starovoitov wrote: On Tue, Mar 4, 2014 at 6:28 AM, Hagen Paul Pfeifer wrote: If all issues raised by Daniel are addresed: Acked-by: Hagen Paul Pfeifer Thanks! But ... Future work: 0. seccomp 1. add extended BPF JIT for x86_64 2. add inband old/new demux

Re: [PATCH v4 net-next 1/3] Extended BPF interpreter and converter

2014-03-04 Thread Daniel Borkmann
On 03/04/2014 06:09 PM, Alexei Starovoitov wrote: On Tue, Mar 4, 2014 at 1:59 AM, Daniel Borkmann wrote: ... Hmm, so the case statement is about BPF_RET | BPF_A and BPF_RET | BPF_K but BPF_RET | BPF_X is not mentioned. However, in BPF_SRC(fp->code) selection you fall back to BPF_X if it doesn'

Re: [PATCH v4 net-next 1/3] Extended BPF interpreter and converter

2014-03-04 Thread Alexei Starovoitov
On Tue, Mar 4, 2014 at 6:28 AM, Hagen Paul Pfeifer wrote: > If all issues raised by Daniel are addresed: > > Acked-by: Hagen Paul Pfeifer Thanks! > But ... > >>Future work: >> >>0. seccomp >> >>1. add extended BPF JIT for x86_64 >> >>2. add inband old/new demux and extended BPF verifier, so tha

Re: [PATCH v4 net-next 1/3] Extended BPF interpreter and converter

2014-03-04 Thread Alexei Starovoitov
On Tue, Mar 4, 2014 at 1:59 AM, Daniel Borkmann wrote: > On 03/04/2014 06:18 AM, Alexei Starovoitov wrote: >> >> Extended BPF extends old BPF in the following ways: >> - from 2 to 10 registers >>Original BPF has two registers (A and X) and hidden frame pointer. >>Extended BPF has ten regis

Re: [PATCH v4 net-next 1/3] Extended BPF interpreter and converter

2014-03-04 Thread Hagen Paul Pfeifer
If all issues raised by Daniel are addresed: Acked-by: Hagen Paul Pfeifer But ... >Future work: > >0. seccomp > >1. add extended BPF JIT for x86_64 > >2. add inband old/new demux and extended BPF verifier, so that new programs > can be loaded through old sk_attach_filter() and > sk_unattache

Re: [PATCH v4 net-next 1/3] Extended BPF interpreter and converter

2014-03-04 Thread Daniel Borkmann
On 03/04/2014 06:18 AM, Alexei Starovoitov wrote: Extended BPF extends old BPF in the following ways: - from 2 to 10 registers Original BPF has two registers (A and X) and hidden frame pointer. Extended BPF has ten registers and read-only frame pointer. - from 32-bit registers to 64-bit reg

[PATCH v4 net-next 1/3] Extended BPF interpreter and converter

2014-03-03 Thread Alexei Starovoitov
Extended BPF extends old BPF in the following ways: - from 2 to 10 registers Original BPF has two registers (A and X) and hidden frame pointer. Extended BPF has ten registers and read-only frame pointer. - from 32-bit registers to 64-bit registers semantics of old 32-bit ALU operations are pr