Re: [PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver

2013-01-08 Thread Boris BREZILLON
On 08/01/2013 08:10, Thierry Reding wrote: > On Thu, Dec 20, 2012 at 10:12:56AM +0100, Boris BREZILLON wrote: >> Hi, >> >> Sorry for resend. The previous version still has alignment issues on >> atmel_tcb_pwm_set_polarity, atmel_tcb_pwm_request and >> atmel_tcb_pwm_config function parameters. >> >

Re: [PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver

2013-01-08 Thread Russell King - ARM Linux
On Tue, Jan 08, 2013 at 04:21:59PM +0100, Boris BREZILLON wrote: > Do I have to break the error string so that the line does not exceed 80 > characters ? No. > Checkpath script does not complain about it, and the CodingStyle file > specify that visible strings should not be broken... Correct. >

Re: [PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver

2013-01-08 Thread Boris BREZILLON
On 08/01/2013 08:10, Thierry Reding wrote: > On Thu, Dec 20, 2012 at 10:12:56AM +0100, Boris BREZILLON wrote: >> Hi, >> >> Sorry for resend. The previous version still has alignment issues on >> atmel_tcb_pwm_set_polarity, atmel_tcb_pwm_request and >> atmel_tcb_pwm_config function parameters. >> >

Re: [PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver

2013-01-08 Thread Thierry Reding
On Tue, Jan 08, 2013 at 01:43:56PM +0100, Boris BREZILLON wrote: > On 08/01/2013 08:10, Thierry Reding wrote: > > On Thu, Dec 20, 2012 at 10:12:56AM +0100, Boris BREZILLON wrote: [...] > >> +static void atmel_tcb_pwm_disable(struct pwm_chip *chip, struct > >> pwm_device *pwm) > >> +{ > > [...] > >

Re: [PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver

2013-01-07 Thread Thierry Reding
On Thu, Dec 20, 2012 at 10:12:56AM +0100, Boris BREZILLON wrote: > Hi, > > Sorry for resend. The previous version still has alignment issues on > atmel_tcb_pwm_set_polarity, atmel_tcb_pwm_request and > atmel_tcb_pwm_config function parameters. > > This patch adds a PWM driver based on Atmel Time

[PATCH v4 RESEND] pwm: atmel: add Timer Counter Block PWM driver

2012-12-20 Thread Boris BREZILLON
Hi, Sorry for resend. The previous version still has alignment issues on atmel_tcb_pwm_set_polarity, atmel_tcb_pwm_request and atmel_tcb_pwm_config function parameters. This patch adds a PWM driver based on Atmel Timer Counter Block. Timer Counter Block is used in Waveform generator mode. A Tim