Re: [PATCH v4 5/6] at24: Support probing while off

2020-08-12 Thread Bartosz Golaszewski
On Wed, Aug 12, 2020 at 9:25 PM Wolfram Sang wrote: > > > > Wolfram says. From my side: I'd prefer to see the > > disable_i2c_core_irq_mapping converted to flags first and then the > > flags extended with whatever you need. disable_i2c_core_irq_mapping > > could also be removed AFAICT - nobody use

Re: [PATCH v4 5/6] at24: Support probing while off

2020-08-12 Thread Wolfram Sang
> Wolfram says. From my side: I'd prefer to see the > disable_i2c_core_irq_mapping converted to flags first and then the > flags extended with whatever you need. disable_i2c_core_irq_mapping > could also be removed AFAICT - nobody uses it. I haven't read the details here, just saying that 'disabl

Re: [PATCH v4 5/6] at24: Support probing while off

2020-08-12 Thread Bartosz Golaszewski
On Tue, Aug 11, 2020 at 10:00 AM Sakari Ailus wrote: > > Hi Bartosz, > > On Mon, Aug 10, 2020 at 08:12:00PM +0200, Bartosz Golaszewski wrote: > > On Mon, Aug 10, 2020 at 10:26 AM Sakari Ailus wrote: > > > > > > > [snip] > > > > > > > > > > Rafael: I think that there are two issues with patch 1/5:

Re: [PATCH v4 5/6] at24: Support probing while off

2020-08-11 Thread Sakari Ailus
Hi Bartosz, On Mon, Aug 10, 2020 at 08:12:00PM +0200, Bartosz Golaszewski wrote: > On Mon, Aug 10, 2020 at 10:26 AM Sakari Ailus wrote: > > > > [snip] > > > > > > > Rafael: I think that there are two issues with patch 1/5: > > > 1. It adds a very specific boolean flag to a structure that's mean

Re: [PATCH v4 5/6] at24: Support probing while off

2020-08-10 Thread Bartosz Golaszewski
On Mon, Aug 10, 2020 at 10:26 AM Sakari Ailus wrote: > [snip] > > > > Rafael: I think that there are two issues with patch 1/5: > > 1. It adds a very specific boolean flag to a structure that's meant to > > be very general. As I pointed out in the i2c patch: at the very least > > this could be m

Re: [PATCH v4 5/6] at24: Support probing while off

2020-08-10 Thread Sakari Ailus
Hi Bartosz, Apologies for the late reply --- I was expecting more discussion which never happened... On Wed, Mar 25, 2020 at 02:48:47PM +0100, Bartosz Golaszewski wrote: > pon., 23 mar 2020 o 22:31 Sakari Ailus > napisaƂ(a): > > > > Bartosz, > > > > On Thu, Mar 12, 2020 at 02:10:32PM +0100, Bart