Re: [PATCH v4 5/5] x86/sgx: Remove redundant if conditions in sgx_encl_create

2021-02-10 Thread Tianjia Zhang
On 2/3/21 6:04 AM, Jarkko Sakkinen wrote: On Mon, Feb 01, 2021 at 09:26:53PM +0800, Tianjia Zhang wrote: In this scenario, there is no case where va_page is NULL, and the error has been checked. The if condition statement here is if-condition, i.e. dash missing Will do in the next patch.

Re: [PATCH v4 5/5] x86/sgx: Remove redundant if conditions in sgx_encl_create

2021-02-02 Thread Jarkko Sakkinen
On Mon, Feb 01, 2021 at 09:26:53PM +0800, Tianjia Zhang wrote: > In this scenario, there is no case where va_page is NULL, and > the error has been checked. The if condition statement here is if-condition, i.e. dash missing > redundant, so remove the condition detection. > > Signed-off-by: Tianj

[PATCH v4 5/5] x86/sgx: Remove redundant if conditions in sgx_encl_create

2021-02-01 Thread Tianjia Zhang
In this scenario, there is no case where va_page is NULL, and the error has been checked. The if condition statement here is redundant, so remove the condition detection. Signed-off-by: Tianjia Zhang --- arch/x86/kernel/cpu/sgx/ioctl.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)