Re: [PATCH v4 3/9] vsprintf: Do not check address of well-known strings

2018-04-10 Thread Andy Shevchenko
On Mon, 2018-04-09 at 14:19 +0200, Petr Mladek wrote: > On Sat 2018-04-07 17:12:35, Andy Shevchenko wrote: > > On Fri, 2018-04-06 at 11:15 +0200, Petr Mladek wrote: > > > On Thu 2018-04-05 15:30:51, Rasmus Villemoes wrote: > > > > On 2018-04-04 10:58, Petr Mladek wrote: > > > > > > > > > Please l

Re: [PATCH v4 3/9] vsprintf: Do not check address of well-known strings

2018-04-09 Thread Petr Mladek
On Sat 2018-04-07 17:12:35, Andy Shevchenko wrote: > On Fri, 2018-04-06 at 11:15 +0200, Petr Mladek wrote: > > On Thu 2018-04-05 15:30:51, Rasmus Villemoes wrote: > > > On 2018-04-04 10:58, Petr Mladek wrote: > > > > We are going to check the address using probe_kernel_address(). It > > > > will >

Re: [PATCH v4 3/9] vsprintf: Do not check address of well-known strings

2018-04-07 Thread Andy Shevchenko
On Fri, 2018-04-06 at 11:15 +0200, Petr Mladek wrote: > On Thu 2018-04-05 15:30:51, Rasmus Villemoes wrote: > > On 2018-04-04 10:58, Petr Mladek wrote: > > > We are going to check the address using probe_kernel_address(). It > > > will > > > be more expensive and it does not make sense for well kno

Re: [PATCH v4 3/9] vsprintf: Do not check address of well-known strings

2018-04-06 Thread Petr Mladek
On Thu 2018-04-05 15:30:51, Rasmus Villemoes wrote: > On 2018-04-04 10:58, Petr Mladek wrote: > > We are going to check the address using probe_kernel_address(). It will > > be more expensive and it does not make sense for well known address. > > > > This patch splits the string() function. The va

Re: [PATCH v4 3/9] vsprintf: Do not check address of well-known strings

2018-04-05 Thread Rasmus Villemoes
On 2018-04-04 10:58, Petr Mladek wrote: > We are going to check the address using probe_kernel_address(). It will > be more expensive and it does not make sense for well known address. > > This patch splits the string() function. The variant without the check > is then used on locations that handl

[PATCH v4 3/9] vsprintf: Do not check address of well-known strings

2018-04-04 Thread Petr Mladek
We are going to check the address using probe_kernel_address(). It will be more expensive and it does not make sense for well known address. This patch splits the string() function. The variant without the check is then used on locations that handle string constants or strings defined as local var