RE: [PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-17 Thread Anton Tikhomirov
Hi Kamil, > Hi Anton, > > > From: Anton Tikhomirov [mailto:av.tikhomi...@samsung.com] > > Sent: Tuesday, December 10, 2013 3:43 AM > > > > Hi Kamil, > > > > Same USB2.0 PHY may be used by several HCDs, for example EHCI and > OHCI. > > Consider the situation, when EHCI stops using the PHY and call

RE: [PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-17 Thread Kamil Debski
Hi Anton, > From: Anton Tikhomirov [mailto:av.tikhomi...@samsung.com] > Sent: Tuesday, December 10, 2013 3:43 AM > > Hi Kamil, > > Same USB2.0 PHY may be used by several HCDs, for example EHCI and OHCI. > Consider the situation, when EHCI stops using the PHY and calls > power_off, then OHCI beco

RE: [PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-09 Thread Anton Tikhomirov
Hi Kamil, Same USB2.0 PHY may be used by several HCDs, for example EHCI and OHCI. Consider the situation, when EHCI stops using the PHY and calls power_off, then OHCI becomes non-operational. In other words, PHY power_on and power_off calls must be balanced. Shall we handle it in your driver? (u

RE: [PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-09 Thread Kamil Debski
Hi, > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Monday, December 09, 2013 8:56 AM > > Hi, > > On Friday 06 December 2013 09:58 PM, Kamil Debski wrote: > > Hi Kishon, > > > > Thank you for the review. > > > >> From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > >> Sent: Frida

Re: [PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-08 Thread Kishon Vijay Abraham I
Hi, On Friday 06 December 2013 09:58 PM, Kamil Debski wrote: Hi Kishon, Thank you for the review. From: Kishon Vijay Abraham I [mailto:kis...@ti.com] Sent: Friday, December 06, 2013 11:59 AM Hi, On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote: Add a new driver for the Exynos USB

RE: [PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-06 Thread Kamil Debski
Hi, > From: Kamil Debski [mailto:k.deb...@samsung.com] > Sent: Friday, December 06, 2013 5:28 PM > > Hi Kishon, > > Thank you for the review. > > > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > > Sent: Friday, December 06, 2013 11:59 AM > > > > Hi, > > > > On Thursday 05 December 2013 0

RE: [PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-06 Thread Kamil Debski
Hi Kishon, Thank you for the review. > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Friday, December 06, 2013 11:59 AM > > Hi, > > On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote: > > Add a new driver for the Exynos USB PHY. The new driver uses the > > generic PHY frame

Re: [PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-06 Thread Kishon Vijay Abraham I
Hi, On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote: > Add a new driver for the Exynos USB PHY. The new driver uses the generic > PHY framework. The driver includes support for the Exynos 4x10 and 4x12 > SoC families. > > Signed-off-by: Kamil Debski > Signed-off-by: Kyungmin Park > --

[PATCH v4 3/9] phy: Add new Exynos USB PHY driver

2013-12-05 Thread Kamil Debski
Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- .../devicetree/bindings/phy/samsung-usbphy.txt | 54 drivers/phy