Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-09-07 Thread Tomasz Figa
On Friday 06 of September 2013 13:01:15 Stephen Warren wrote: > On 09/06/2013 12:53 AM, Tero Kristo wrote: > > On 09/05/2013 11:30 PM, Stephen Warren wrote: > ... > > >> 1) > >> > >> At least for large SoCs (rather than e.g. a simple clock generator > >> chip/crystal with 1 or 2 outputs), clock d

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-09-06 Thread Saravana Kannan
On 09/06/2013 12:01 PM, Stephen Warren wrote: On 09/06/2013 12:53 AM, Tero Kristo wrote: On 09/05/2013 11:30 PM, Stephen Warren wrote: ... 1) At least for large SoCs (rather than e.g. a simple clock generator chip/crystal with 1 or 2 outputs), clock drivers need a *lot* of data. We can eithe

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-09-06 Thread Stephen Warren
On 09/06/2013 12:53 AM, Tero Kristo wrote: > On 09/05/2013 11:30 PM, Stephen Warren wrote: ... >> 1) >> >> At least for large SoCs (rather than e.g. a simple clock generator >> chip/crystal with 1 or 2 outputs), clock drivers need a *lot* of data. >> We can either: >> >> a) Put that data into the

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-09-05 Thread Tero Kristo
Hi, Chirping in my thoughts below. On 09/05/2013 11:30 PM, Stephen Warren wrote: On 09/05/2013 12:29 PM, Mike Turquette wrote: On Wed, Sep 4, 2013 at 11:36 AM, Stephen Warren wrote: On 09/03/2013 05:22 PM, Mike Turquette wrote: Quoting Stephen Warren (2013-08-30 14:37:46) On 08/30/2013 02:

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-09-05 Thread Stephen Warren
On 09/05/2013 12:29 PM, Mike Turquette wrote: > On Wed, Sep 4, 2013 at 11:36 AM, Stephen Warren wrote: >> On 09/03/2013 05:22 PM, Mike Turquette wrote: >>> Quoting Stephen Warren (2013-08-30 14:37:46) On 08/30/2013 02:33 PM, Mike Turquette wrote: >> ... > The clock _data_ seems to always

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-09-05 Thread Sylwester Nawrocki
On 09/05/2013 10:30 PM, Stephen Warren wrote: On 09/05/2013 12:29 PM, Mike Turquette wrote: > On Wed, Sep 4, 2013 at 11:36 AM, Stephen Warren wrote: >> On 09/03/2013 05:22 PM, Mike Turquette wrote: >>> Quoting Stephen Warren (2013-08-30 14:37:46) On 08/30/2013 02:33 PM, Mike Turque

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-09-05 Thread Mike Turquette
On Wed, Sep 4, 2013 at 11:36 AM, Stephen Warren wrote: > On 09/03/2013 05:22 PM, Mike Turquette wrote: >> Quoting Stephen Warren (2013-08-30 14:37:46) >>> On 08/30/2013 02:33 PM, Mike Turquette wrote: > ... The clock _data_ seems to always have some churn to it. Moving it out to DT reduc

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-09-04 Thread Stephen Warren
On 09/03/2013 05:22 PM, Mike Turquette wrote: > Quoting Stephen Warren (2013-08-30 14:37:46) >> On 08/30/2013 02:33 PM, Mike Turquette wrote: ... >>> The clock _data_ seems to always have some churn to it. Moving it out to >>> DT reduces that churn from Linux. My concern above is not about kernel >

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-08-30 Thread Stephen Warren
On 08/30/2013 02:33 PM, Mike Turquette wrote: > Quoting Kumar Gala (2013-08-30 13:02:42) >> On Aug 28, 2013, at 8:14 PM, Mike Turquette wrote: >> >>> Quoting Kumar Gala (2013-08-28 08:50:10) On Aug 22, 2013, at 12:53 AM, Mike Turquette wrote: > Device Tree binding for the basic clock

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-08-30 Thread Kumar Gala
On Aug 30, 2013, at 3:33 PM, Mike Turquette wrote: > Quoting Kumar Gala (2013-08-30 13:02:42) >> On Aug 28, 2013, at 8:14 PM, Mike Turquette wrote: >> >>> Quoting Kumar Gala (2013-08-28 08:50:10) On Aug 22, 2013, at 12:53 AM, Mike Turquette wrote: > Device Tree binding for the bas

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-08-30 Thread Kumar Gala
On Aug 28, 2013, at 8:14 PM, Mike Turquette wrote: > Quoting Kumar Gala (2013-08-28 08:50:10) >> On Aug 22, 2013, at 12:53 AM, Mike Turquette wrote: >> >>> Device Tree binding for the basic clock multiplexer, plus the setup >>> function to register the clock. Based on the existing fixed-clock >

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-08-29 Thread Tony Lindgren
* Tero Kristo [130829 00:06]: > On 08/29/2013 04:14 AM, Mike Turquette wrote: > > > >The mux-clock binding covers a quite a few platforms that have similar > >mux-clock programming requirements. If the DT binding is verbose enough > >then the basic mux clock driver is sufficient to initialize all

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-08-29 Thread Tero Kristo
On 08/29/2013 04:14 AM, Mike Turquette wrote: Quoting Kumar Gala (2013-08-28 08:50:10) On Aug 22, 2013, at 12:53 AM, Mike Turquette wrote: Device Tree binding for the basic clock multiplexer, plus the setup function to register the clock. Based on the existing fixed-clock binding. Includes m

Re: [PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-08-28 Thread Kumar Gala
On Aug 22, 2013, at 12:53 AM, Mike Turquette wrote: > Device Tree binding for the basic clock multiplexer, plus the setup > function to register the clock. Based on the existing fixed-clock > binding. > > Includes minor beautification of clk-provider.h where some whitespace is > added and of_fi

[PATCH v4 3/5] clk: dt: binding for basic multiplexer clock

2013-08-21 Thread Mike Turquette
Device Tree binding for the basic clock multiplexer, plus the setup function to register the clock. Based on the existing fixed-clock binding. Includes minor beautification of clk-provider.h where some whitespace is added and of_fixed_factor_clock_setup is relocated to maintain a consistent style