Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-27 Thread Luis R. Rodriguez
On Fri, Jan 27, 2017 at 12:53:38PM -0800, Linus Torvalds wrote: > On Fri, Jan 27, 2017 at 10:23 AM, Luis R. Rodriguez wrote: > >> So I'm really not seeing why you want to make these conversions that > >> just make code worse. > > > > The real goal here was first to actually provide a flexible API

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-27 Thread Luis R. Rodriguez
On Fri, Jan 27, 2017 at 03:39:36PM +0100, Rafał Miłecki wrote: > On 27 January 2017 at 15:30, Greg KH wrote: > > On Fri, Jan 27, 2017 at 03:14:14PM +0100, Rafał Miłecki wrote: > >> > Does that patch really "simplify" anything? Anyway, resend it if the > >> > maintainer of the subsystem ignores it

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-27 Thread Linus Torvalds
On Fri, Jan 27, 2017 at 10:23 AM, Luis R. Rodriguez wrote: >> So I'm really not seeing why you want to make these conversions that >> just make code worse. > > The real goal here was first to actually provide a flexible API to enable > more advanced features to be added without having to affect ex

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-27 Thread Luis R. Rodriguez
On Thu, Jan 26, 2017 at 01:54:20PM -0800, Linus Torvalds wrote: > On Thu, Jan 26, 2017 at 1:50 PM, Luis R. Rodriguez wrote: > > > > OK I've added a respective helper call which would map 1-1 with the > > old sync mechanism to enable a 1-1 change, this will be called > > driver_data_request_simple(

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-27 Thread Rafał Miłecki
On 27 January 2017 at 15:30, Greg KH wrote: > On Fri, Jan 27, 2017 at 03:14:14PM +0100, Rafał Miłecki wrote: >> > Does that patch really "simplify" anything? Anyway, resend it if the >> > maintainer of the subsystem ignores it (you did cc: the correct people, >> > right?) >> >> According to the M

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-27 Thread Greg KH
On Fri, Jan 27, 2017 at 03:14:14PM +0100, Rafał Miłecki wrote: > > Does that patch really "simplify" anything? Anyway, resend it if the > > maintainer of the subsystem ignores it (you did cc: the correct people, > > right?) > > According to the MAINTAINERS there isn't firmware API tree / > mainta

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-27 Thread Rafał Miłecki
On 27 January 2017 at 15:07, Greg KH wrote: > On Fri, Jan 27, 2017 at 12:25:48PM +0100, Rafał Miłecki wrote: >> On 27 January 2017 at 08:47, Greg KH wrote: >> > On Thu, Jan 26, 2017 at 10:50:05PM +0100, Luis R. Rodriguez wrote: >> >> On Thu, Jan 19, 2017 at 05:27:51PM +0100, Luis R. Rodriguez wro

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-27 Thread Greg KH
On Fri, Jan 27, 2017 at 12:25:48PM +0100, Rafał Miłecki wrote: > On 27 January 2017 at 08:47, Greg KH wrote: > > On Thu, Jan 26, 2017 at 10:50:05PM +0100, Luis R. Rodriguez wrote: > >> On Thu, Jan 19, 2017 at 05:27:51PM +0100, Luis R. Rodriguez wrote: > >> > On Thu, Jan 19, 2017 at 12:38:57PM +010

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-27 Thread Rafał Miłecki
On 27 January 2017 at 08:47, Greg KH wrote: > On Thu, Jan 26, 2017 at 10:50:05PM +0100, Luis R. Rodriguez wrote: >> On Thu, Jan 19, 2017 at 05:27:51PM +0100, Luis R. Rodriguez wrote: >> > On Thu, Jan 19, 2017 at 12:38:57PM +0100, Greg KH wrote: >> > > On Thu, Jan 12, 2017 at 07:02:44AM -0800, Luis

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-26 Thread Greg KH
On Thu, Jan 26, 2017 at 10:50:05PM +0100, Luis R. Rodriguez wrote: > On Thu, Jan 19, 2017 at 05:27:51PM +0100, Luis R. Rodriguez wrote: > > On Thu, Jan 19, 2017 at 12:38:57PM +0100, Greg KH wrote: > > > On Thu, Jan 12, 2017 at 07:02:44AM -0800, Luis R. Rodriguez wrote: > > > > --- > > > > drivers/

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-26 Thread Linus Torvalds
On Thu, Jan 26, 2017 at 1:50 PM, Luis R. Rodriguez wrote: > > OK I've added a respective helper call which would map 1-1 with the > old sync mechanism to enable a 1-1 change, this will be called > driver_data_request_simple(), but let me know if there is a preference > for something else. So just

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-26 Thread Luis R. Rodriguez
On Thu, Jan 19, 2017 at 05:27:51PM +0100, Luis R. Rodriguez wrote: > On Thu, Jan 19, 2017 at 12:38:57PM +0100, Greg KH wrote: > > On Thu, Jan 12, 2017 at 07:02:44AM -0800, Luis R. Rodriguez wrote: > > > --- > > > drivers/net/wireless/intersil/p54/eeprom.c | 2 +- > > > drivers/net/wireless/inters

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-19 Thread Luis R. Rodriguez
On Thu, Jan 19, 2017 at 12:38:57PM +0100, Greg KH wrote: > On Thu, Jan 12, 2017 at 07:02:44AM -0800, Luis R. Rodriguez wrote: > > The Coccinelle sysdata patches were used to help with > > this transition. The changes have been carefully manually > > vetted for. With the conversion we modify the cas

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-19 Thread Greg KH
On Thu, Jan 12, 2017 at 07:02:44AM -0800, Luis R. Rodriguez wrote: > The Coccinelle sysdata patches were used to help with > this transition. The changes have been carefully manually > vetted for. With the conversion we modify the cases that do > not need the firmware to be kept so that the sysdata

Re: [PATCH v4 3/3] p54: convert to sysdata API

2017-01-16 Thread Christian Lamparter
On Thursday, January 12, 2017 7:02:44 AM CET Luis R. Rodriguez wrote: > The Coccinelle sysdata patches were used to help with > this transition. The changes have been carefully manually > vetted for. With the conversion we modify the cases that do > not need the firmware to be kept so that the sysd

[PATCH v4 3/3] p54: convert to sysdata API

2017-01-12 Thread Luis R. Rodriguez
The Coccinelle sysdata patches were used to help with this transition. The changes have been carefully manually vetted for. With the conversion we modify the cases that do not need the firmware to be kept so that the sysdata API can release it for us. Using the new sysdata API also means we can get