Re: [PATCH v4 3/3] gpiolib: Show correct direction from the beginning

2018-10-05 Thread Jeffrey Hugo
On 10/5/2018 12:52 AM, Ricardo Ribalda Delgado wrote: Hi On Fri, Oct 5, 2018 at 12:26 AM Jeffrey Hugo wrote: On 10/2/2018 9:21 AM, Jeffrey Hugo wrote: On 10/2/2018 8:08 AM, Ricardo Ribalda Delgado wrote: Current code assumes that the direction is input if direction_input function is set. Thi

Re: [PATCH v4 3/3] gpiolib: Show correct direction from the beginning

2018-10-04 Thread Ricardo Ribalda Delgado
Hi On Fri, Oct 5, 2018 at 12:26 AM Jeffrey Hugo wrote: > > On 10/2/2018 9:21 AM, Jeffrey Hugo wrote: > > On 10/2/2018 8:08 AM, Ricardo Ribalda Delgado wrote: > >> Current code assumes that the direction is input if direction_input > >> function is set. > >> This might not be the case on GPIOs with

Re: [PATCH v4 3/3] gpiolib: Show correct direction from the beginning

2018-10-04 Thread Jeffrey Hugo
On 10/2/2018 9:21 AM, Jeffrey Hugo wrote: On 10/2/2018 8:08 AM, Ricardo Ribalda Delgado wrote: Current code assumes that the direction is input if direction_input function is set. This might not be the case on GPIOs with programmable direction. Signed-off-by: Ricardo Ribalda Delgado I'll try

Re: [PATCH v4 3/3] gpiolib: Show correct direction from the beginning

2018-10-02 Thread Jeffrey Hugo
On 10/2/2018 8:08 AM, Ricardo Ribalda Delgado wrote: Current code assumes that the direction is input if direction_input function is set. This might not be the case on GPIOs with programmable direction. Signed-off-by: Ricardo Ribalda Delgado I'll try to get this series tested on QDF2400 by th

[PATCH v4 3/3] gpiolib: Show correct direction from the beginning

2018-10-02 Thread Ricardo Ribalda Delgado
Current code assumes that the direction is input if direction_input function is set. This might not be the case on GPIOs with programmable direction. Signed-off-by: Ricardo Ribalda Delgado --- Changelog v4: ti...@kernel.org: Remove REVISIT comment drivers/gpio/gpiolib.c | 27 +-