Re: [PATCH v4 2/9] ppc64le FTRACE_WITH_REGS implementation

2016-01-05 Thread Torsten Duwe
On Wed, Dec 02, 2015 at 09:18:05AM +1100, Michael Ellerman wrote: > > I (still) haven't had a chance to have a good look at it, but I won't this > week > anyway. So post v5 and hopefully I can review that and it will be perfect :) The perfect v5 is there now, for 4 weeks minus the holiday season

Re: [PATCH v4 2/9] ppc64le FTRACE_WITH_REGS implementation

2015-12-01 Thread Michael Ellerman
On Tue, 2015-12-01 at 18:29 +0100, Torsten Duwe wrote: > On Thu, Nov 26, 2015 at 01:04:19PM +0300, Denis Kirjanov wrote: > > > diff --git a/arch/powerpc/kernel/entry_64.S > > > b/arch/powerpc/kernel/entry_64.S > > > index 8d56b16..3309dd8 100644 > > > --- a/arch/powerpc/kernel/entry_64.S > > > +++

Re: [PATCH v4 2/9] ppc64le FTRACE_WITH_REGS implementation

2015-12-01 Thread Torsten Duwe
On Thu, Nov 26, 2015 at 01:04:19PM +0300, Denis Kirjanov wrote: > > diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S > > index 8d56b16..3309dd8 100644 > > --- a/arch/powerpc/kernel/entry_64.S > > +++ b/arch/powerpc/kernel/entry_64.S > Linux style for comments is the C89.

Re: [PATCH v4 2/9] ppc64le FTRACE_WITH_REGS implementation

2015-11-26 Thread Torsten Duwe
On Thu, Nov 26, 2015 at 01:04:19PM +0300, Denis Kirjanov wrote: > On 11/25/15, Torsten Duwe wrote: > > --- a/arch/powerpc/kernel/entry_64.S > > +++ b/arch/powerpc/kernel/entry_64.S > Linux style for comments is the C89. Please update entry_64.S I might as well switch to asm-style comments. Anyway

Re: [PATCH v4 2/9] ppc64le FTRACE_WITH_REGS implementation

2015-11-26 Thread Denis Kirjanov
On 11/25/15, Torsten Duwe wrote: > Implement FTRACE_WITH_REGS for powerpc64, on ELF ABI v2. > Initial work started by Vojtech Pavlik, used with permission. > > * arch/powerpc/kernel/entry_64.S: > - Implement an effective ftrace_caller that works from > within the kernel binary as well

[PATCH v4 2/9] ppc64le FTRACE_WITH_REGS implementation

2015-11-25 Thread Torsten Duwe
Implement FTRACE_WITH_REGS for powerpc64, on ELF ABI v2. Initial work started by Vojtech Pavlik, used with permission. * arch/powerpc/kernel/entry_64.S: - Implement an effective ftrace_caller that works from within the kernel binary as well as from modules. * arch/powerpc/kernel/ftra