Re: [PATCH v4 2/5] soc: qcom: Introduce QMI helpers

2017-11-30 Thread Philippe Ombredanne
On Fri, Dec 1, 2017 at 6:35 AM, Bjorn Andersson wrote: > On Thu 30 Nov 00:18 PST 2017, Philippe Ombredanne wrote: > >> Bjorn, >> >> On Thu, Nov 30, 2017 at 2:16 AM, Bjorn Andersson >> wrote: >> [] >> > diff --git a/drivers/soc/qcom/qmi_interface.c >> > b/drivers/soc/qcom/qmi_interface.c >> > new

Re: [PATCH v4 2/5] soc: qcom: Introduce QMI helpers

2017-11-30 Thread Bjorn Andersson
On Thu 30 Nov 00:18 PST 2017, Philippe Ombredanne wrote: > Bjorn, > > On Thu, Nov 30, 2017 at 2:16 AM, Bjorn Andersson > wrote: > [] > > diff --git a/drivers/soc/qcom/qmi_interface.c > > b/drivers/soc/qcom/qmi_interface.c > > new file mode 100644 > > index ..4027b52b0834 > > --- /de

Re: [PATCH v4 2/5] soc: qcom: Introduce QMI helpers

2017-11-30 Thread Chris Lew
On 11/29/2017 5:16 PM, Bjorn Andersson wrote: Drivers that needs to communicate with a remote QMI service all has to perform the operations of discovering the service, encoding and decoding the messages and operate the socket. This introduces an abstraction for these common operations, reducing

Re: [PATCH v4 2/5] soc: qcom: Introduce QMI helpers

2017-11-30 Thread Philippe Ombredanne
Bjorn, On Thu, Nov 30, 2017 at 2:16 AM, Bjorn Andersson wrote: [] > diff --git a/drivers/soc/qcom/qmi_interface.c > b/drivers/soc/qcom/qmi_interface.c > new file mode 100644 > index ..4027b52b0834 > --- /dev/null > +++ b/drivers/soc/qcom/qmi_interface.c > @@ -0,0 +1,857 @@ > +/* > +

[PATCH v4 2/5] soc: qcom: Introduce QMI helpers

2017-11-29 Thread Bjorn Andersson
Drivers that needs to communicate with a remote QMI service all has to perform the operations of discovering the service, encoding and decoding the messages and operate the socket. This introduces an abstraction for these common operations, reducing most of the duplication in such cases. Tested-By