Re: [PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-18 Thread Denis OSTERLAND
Hi, Am Mittwoch, den 18.07.2018, 10:13 +0200 schrieb Alexandre Belloni: > On 10/07/2018 09:44:15+, Denis OSTERLAND wrote: > >  > > + if (id->driver_data == TYPE_ISL1219) { > > + rc = ISL1219_REG_EV_EVEN; > > + rc = i2c_smbus_write_byte_data(client, ISL1219_REG_EV, rc); >

Re: [PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-18 Thread Alexandre Belloni
On 10/07/2018 09:44:15+, Denis OSTERLAND wrote: > static int > isl1208_probe(struct i2c_client *client, const struct i2c_device_id *id) > { > @@ -642,6 +744,7 @@ isl1208_probe(struct i2c_client *client, const struct > i2c_device_id *id) > rtc->ops = &isl1208_rtc_ops; > > i2c_se

Re: [PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-10 Thread Ye Xiaolong
Hi, Denis The patch was applied in correct sequence as you can see in the github link. I think the question here is rtc-isl1208 can be built as a built-in module, but it would fail if it was built as a ko. Thanks, Xiaolong On 07/10, Denis OSTERLAND wrote: >Hi, > >seems 2/5 was applied before 1/

Re: [PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-10 Thread Denis OSTERLAND
Hi, seems 2/5 was applied before 1/5. 1/5 introduces rtc_add_group. Regards Denis Am Dienstag, den 10.07.2018, 21:20 +0800 schrieb kbuild test robot: > Hi Michael, > > I love your patch! Yet something to improve: > > [auto build test ERROR on abelloni/rtc-next] > [also build test ERROR on v4.1

Re: [PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-10 Thread kbuild test robot
Hi Michael, I love your patch! Yet something to improve: [auto build test ERROR on abelloni/rtc-next] [also build test ERROR on v4.18-rc4 next-20180709] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/c

[PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection

2018-07-10 Thread Denis OSTERLAND
From: Michael Grzeschik We add support for the ISL1219 chip that got an integrated tamper detection function. This patch implements the feature by adding an additional timestamp0 file to sysfs device path. This file contains seconds since epoch, if an event occurred, or is empty, if none occurred