Re: [PATCH v4 2/5] fs: Check if utf8 encoding is loaded before calling utf8_unload()

2021-03-25 Thread Eric Biggers
On Thu, Mar 25, 2021 at 03:31:42PM -0400, Gabriel Krisman Bertazi wrote: > Eric Biggers writes: > > > On Thu, Mar 25, 2021 at 05:38:08AM +0530, Shreeya Patel wrote: > >> utf8_unload is being called if CONFIG_UNICODE is enabled. > >> The ifdef block doesn't check if utf8 encoding has been loaded >

Re: [PATCH v4 2/5] fs: Check if utf8 encoding is loaded before calling utf8_unload()

2021-03-25 Thread Gabriel Krisman Bertazi
Eric Biggers writes: > On Thu, Mar 25, 2021 at 05:38:08AM +0530, Shreeya Patel wrote: >> utf8_unload is being called if CONFIG_UNICODE is enabled. >> The ifdef block doesn't check if utf8 encoding has been loaded >> or not before calling the utf8_unload() function. >> This is not the expected beh

Re: [PATCH v4 2/5] fs: Check if utf8 encoding is loaded before calling utf8_unload()

2021-03-25 Thread Eric Biggers
On Thu, Mar 25, 2021 at 05:38:08AM +0530, Shreeya Patel wrote: > utf8_unload is being called if CONFIG_UNICODE is enabled. > The ifdef block doesn't check if utf8 encoding has been loaded > or not before calling the utf8_unload() function. > This is not the expected behavior since it would sometime

[PATCH v4 2/5] fs: Check if utf8 encoding is loaded before calling utf8_unload()

2021-03-24 Thread Shreeya Patel
utf8_unload is being called if CONFIG_UNICODE is enabled. The ifdef block doesn't check if utf8 encoding has been loaded or not before calling the utf8_unload() function. This is not the expected behavior since it would sometimes lead to unloading utf8 even before loading it. Hence, add a condition