Re: [PATCH v4 2/4] gpio/xilinx: Convert the driver to platform device interface

2014-12-17 Thread Ricardo Ribalda Delgado
Hello I cannot do only of_mm_gpiochip_remove before only_one_gpio_device, because I have to restore the initial io address :S. Anyway I have prepared a new patchset with hopefully all you need. I have resend also the old patches so you can have a general view. I think that only gpio-mpc5200.c wou

Re: [PATCH v4 2/4] gpio/xilinx: Convert the driver to platform device interface

2014-12-17 Thread Alexandre Courbot
On Wed, Dec 17, 2014 at 10:31 PM, Ricardo Ribalda Delgado wrote: > On Wed, Dec 17, 2014 at 2:26 PM, Alexandre Courbot wrote: >> On Wed, Dec 17, 2014 at 8:02 PM, Ricardo Ribalda Delgado >> wrote: >>> Hello Alexandre >>> This should not be here. The mapping and call to gpiochip_add() are

Re: [PATCH v4 2/4] gpio/xilinx: Convert the driver to platform device interface

2014-12-17 Thread Ricardo Ribalda Delgado
On Wed, Dec 17, 2014 at 2:26 PM, Alexandre Courbot wrote: > On Wed, Dec 17, 2014 at 8:02 PM, Ricardo Ribalda Delgado > wrote: >> Hello Alexandre >> >>> This should not be here. The mapping and call to gpiochip_add() are >>> performed by of_mm_gpiochip_add(). We should thus have a >>> of_mm_gpioch

Re: [PATCH v4 2/4] gpio/xilinx: Convert the driver to platform device interface

2014-12-17 Thread Alexandre Courbot
On Wed, Dec 17, 2014 at 8:02 PM, Ricardo Ribalda Delgado wrote: > Hello Alexandre > >> This should not be here. The mapping and call to gpiochip_add() are >> performed by of_mm_gpiochip_add(). We should thus have a >> of_mm_gpiochip_remove() function that undoes what _add did instead of >> expecte

Re: [PATCH v4 2/4] gpio/xilinx: Convert the driver to platform device interface

2014-12-17 Thread Ricardo Ribalda Delgado
Hello Alexandre > This should not be here. The mapping and call to gpiochip_add() are > performed by of_mm_gpiochip_add(). We should thus have a > of_mm_gpiochip_remove() function that undoes what _add did instead of > expected all users to do unmap themselves. Can you add a patch to your > series

Re: [PATCH v4 2/4] gpio/xilinx: Convert the driver to platform device interface

2014-12-16 Thread Alexandre Courbot
On Thu, Dec 11, 2014 at 12:56 AM, Ricardo Ribalda Delgado wrote: > This way we do not need to transverse the device tree manually and we > support hot plugged devices. > > Also Implement remove callback so the driver can be unloaded > > Signed-off-by: Ricardo Ribalda Delgado > --- > > v4: Add mis

Re: [PATCH v4 2/4] gpio/xilinx: Convert the driver to platform device interface

2014-12-11 Thread Michal Simek
On 12/10/2014 04:56 PM, Ricardo Ribalda Delgado wrote: > This way we do not need to transverse the device tree manually and we > support hot plugged devices. > > Also Implement remove callback so the driver can be unloaded > > Signed-off-by: Ricardo Ribalda Delgado > --- > > v4: Add missing mod

[PATCH v4 2/4] gpio/xilinx: Convert the driver to platform device interface

2014-12-10 Thread Ricardo Ribalda Delgado
This way we do not need to transverse the device tree manually and we support hot plugged devices. Also Implement remove callback so the driver can be unloaded Signed-off-by: Ricardo Ribalda Delgado --- v4: Add missing module_exit drivers/gpio/gpio-xilinx.c | 83 ++