Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints

2016-08-31 Thread Binoy Jayan
Hi Steven/Daniel, On 30 August 2016 at 19:38, Steven Rostedt wrote: >> + >> + TP_printk("ltype=%d, latency=%lu", >> + __entry->ltype, (unsigned long) __entry->latency) > > The print of ltype should be text and not a number. Well, you could > have both text and a number, but a numb

Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints

2016-08-30 Thread Steven Rostedt
On Tue, 30 Aug 2016 15:58:43 +0530 Binoy Jayan wrote: > This work is based on work by Daniel Wagner. A few tracepoints are added > at the end of the critical section. With the hist trigger in place, the > hist trigger plots may be generated, with per-cpu breakdown of events > captured. It is base

Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints

2016-08-30 Thread Binoy Jayan
Hi Daniel, On 30 August 2016 at 17:00, Daniel Wagner wrote: > Hi Binoy, > > > As Masami has pointed out, the prefix trace_ should not be used. Also having > trace_latency_ and latency_trace_ is kind of confusing. What about > {start|stop}_latency_timing()? It would match the existing > {start|sto

Re: [PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints

2016-08-30 Thread Daniel Wagner
Hi Binoy, On 08/30/2016 12:28 PM, Binoy Jayan wrote: +static inline void trace_latency_preempt_mark_ts(enum latency_type ltype) +{ + this_cpu_write(lat_ts[ltype], (cycle_t) trace_clock_local()); +} + +static inline void latency_trace(enum latency_type type) +{ + trace_latency_preempt

[PATCH v4 2/3] tracing: Add trace_irqsoff tracepoints

2016-08-30 Thread Binoy Jayan
This work is based on work by Daniel Wagner. A few tracepoints are added at the end of the critical section. With the hist trigger in place, the hist trigger plots may be generated, with per-cpu breakdown of events captured. It is based on linux kernel's event infrastructure. The following filter(