Re: [PATCH v4 2/3] iio: light: Add support for vishay vcnl4035

2018-08-03 Thread Jonathan Cameron
On Thu, 2 Aug 2018 22:34:14 +0300 Andy Shevchenko wrote: > On Thu, Aug 2, 2018 at 9:27 PM, Parthiban Nallathambi wrote: > > Add support for VCNL4035, which is capable of Ambient light > > sensing (ALS) and proximity function. This patch adds support > > only for ALS function > > > +#include

Re: [PATCH v4 2/3] iio: light: Add support for vishay vcnl4035

2018-08-02 Thread Andy Shevchenko
On Thu, Aug 2, 2018 at 9:27 PM, Parthiban Nallathambi wrote: > Add support for VCNL4035, which is capable of Ambient light > sensing (ALS) and proximity function. This patch adds support > only for ALS function > +#include > +#include > +#include > +#include > +#include Sort? > +#include

Re: [PATCH v4 2/3] iio: light: Add support for vishay vcnl4035

2018-08-02 Thread Peter Meerwald-Stadler
On Thu, 2 Aug 2018, Parthiban Nallathambi wrote: > Add support for VCNL4035, which is capable of Ambient light > sensing (ALS) and proximity function. This patch adds support > only for ALS function comment below > Signed-off-by: Parthiban Nallathambi > > Changelog since v1: > > 1. Fixed 0-d

[PATCH v4 2/3] iio: light: Add support for vishay vcnl4035

2018-08-02 Thread Parthiban Nallathambi
Add support for VCNL4035, which is capable of Ambient light sensing (ALS) and proximity function. This patch adds support only for ALS function Signed-off-by: Parthiban Nallathambi Changelog since v1: 1. Fixed 0-day warning on le16_to_cpu usage 2. Persistence value is directly mapped to datashe