Re: [PATCH v4 2/2] soc: qcom: add l2 cache perf events driver

2016-09-16 Thread Neil Leeder
On 9/16/2016 12:40 PM, Mark Rutland wrote: > On Fri, Sep 16, 2016 at 11:33:39AM -0400, Neil Leeder wrote: [...] >> On 9/1/2016 12:30 PM, Mark Rutland wrote: >>> On Tue, Aug 30, 2016 at 01:01:33PM -0400, Neil Leeder wrote: + /* Don't allow groups with mixed PMUs, except for s/w events */

Re: [PATCH v4 2/2] soc: qcom: add l2 cache perf events driver

2016-09-16 Thread Mark Rutland
On Fri, Sep 16, 2016 at 11:33:39AM -0400, Neil Leeder wrote: > Hi Mark, > Thank you for the thorough review. I will post an updated patchset > which addresses all of your comments. There is just one outstanding > comment which I have a question about: [...] > On 9/1/2016 12:30 PM, Mark Rutland wr

Re: [PATCH v4 2/2] soc: qcom: add l2 cache perf events driver

2016-09-16 Thread Neil Leeder
Hi Mark, Thank you for the thorough review. I will post an updated patchset which addresses all of your comments. There is just one outstanding comment which I have a question about: On 9/1/2016 12:30 PM, Mark Rutland wrote: > On Tue, Aug 30, 2016 at 01:01:33PM -0400, Neil Leeder wrote: >> +sta

Re: [PATCH v4 2/2] soc: qcom: add l2 cache perf events driver

2016-09-02 Thread Mark Rutland
On Thu, Sep 01, 2016 at 05:30:52PM +0100, Mark Rutland wrote: > On Tue, Aug 30, 2016 at 01:01:33PM -0400, Neil Leeder wrote: > > +static DEFINE_MUTEX(l2cache_pmu_mutex); > > A mutex (which can sleep) is not safe for the hotplug state machine > stuff. See recent patches to the arm_pmu code. > > Th

Re: [PATCH v4 2/2] soc: qcom: add l2 cache perf events driver

2016-09-01 Thread Mark Rutland
Hi Neil, On Tue, Aug 30, 2016 at 01:01:33PM -0400, Neil Leeder wrote: > Adds perf events support for L2 cache PMU. > > The L2 cache PMU driver is named 'l2cache_0' and can be used > with perf events to profile L2 events such as cache hits > and misses. > > Signed-off-by: Neil Leeder > --- > dr

[PATCH v4 2/2] soc: qcom: add l2 cache perf events driver

2016-08-30 Thread Neil Leeder
Adds perf events support for L2 cache PMU. The L2 cache PMU driver is named 'l2cache_0' and can be used with perf events to profile L2 events such as cache hits and misses. Signed-off-by: Neil Leeder --- drivers/soc/qcom/Kconfig | 10 + drivers/soc/qcom/Makefile |