Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master

2017-04-09 Thread Benjamin Herrenschmidt
On Sun, 2017-04-09 at 16:22 -0500, Christopher Bostic wrote: > A 3 microsecond delay is required, however, to prevent occasional issues  > during heavy FSI bus load stress testing. > A 1 nanosecond delay using ndelay(1) had been specified prior to this  > but after looking more closely at real time

Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master

2017-04-09 Thread Benjamin Herrenschmidt
On Mon, 2017-04-10 at 07:53 +1000, Benjamin Herrenschmidt wrote: > FYI. pdbg in userspace operates without any  delays in practice, the > overhead between the various load/store instructions seems > sufficient. > > The only delay that's needed is when going through the FSI2PIB (to do > SCOMs) wher

Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master

2017-04-09 Thread Benjamin Herrenschmidt
On Mon, 2017-04-10 at 07:41 +1000, Benjamin Herrenschmidt wrote: > On Sun, 2017-04-09 at 16:22 -0500, Christopher Bostic wrote: > > A 3 microsecond delay is required, however, to prevent occasional > > issues  > > during heavy FSI bus load stress testing. > > A 1 nanosecond delay using ndelay(1) ha

Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master

2017-04-09 Thread Christopher Bostic
On 4/4/17 5:19 PM, Benjamin Herrenschmidt wrote: On Tue, 2017-04-04 at 12:32 -0500, Christopher Bostic wrote: Agreed that there is room for improvement. I intend to look further into your suggestions from here and our private conversation on the matter and make changes as appropriate. I hav

Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master

2017-04-04 Thread Christopher Bostic
On 4/4/17 5:19 PM, Benjamin Herrenschmidt wrote: On Tue, 2017-04-04 at 12:32 -0500, Christopher Bostic wrote: Agreed that there is room for improvement. I intend to look further into your suggestions from here and our private conversation on the matter and make changes as appropriate. I hav

Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master

2017-04-04 Thread Benjamin Herrenschmidt
On Tue, 2017-04-04 at 12:32 -0500, Christopher Bostic wrote: > Agreed that there is room for improvement.   I intend to look further  > into your suggestions from here and our private conversation on the  > matter and make changes as appropriate.  I have an open issue to track  > this.  As it exist

Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master (fwd)

2017-04-04 Thread Christopher Bostic
Chris julia -- Forwarded message -- Date: Fri, 31 Mar 2017 00:15:09 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master Hi Chris, [auto build test WARNING on linus/master] [also build test WARNING on

Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master

2017-04-04 Thread Christopher Bostic
On 3/30/17 3:50 PM, Benjamin Herrenschmidt wrote: On Thu, 2017-03-30 at 13:15 -0500, Christopher Bostic wrote: +static void serial_in(struct fsi_master_gpio *master, struct fsi_gpio_msg *msg, + uint8_t num_bits) +{ + uint8_t bit, in_bit; + + set_sda_input(mast

Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master

2017-03-30 Thread Joel Stanley
On Fri, Mar 31, 2017 at 4:45 AM, Christopher Bostic wrote: > Where would you recommend they be placed? I assume we want them somewhere > in the patch set. Send them as a separate patch set to the Aspeed maintainer (me) and the ARM list. Cheers, Joel

Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master (fwd)

2017-03-30 Thread Julia Lawall
Is master on line 514 allocated with kmalloc, or the devm call on line 522? julia -- Forwarded message -- Date: Fri, 31 Mar 2017 00:15:09 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master Hi

Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master

2017-03-30 Thread Benjamin Herrenschmidt
On Thu, 2017-03-30 at 13:15 -0500, Christopher Bostic wrote: > > > +static void serial_in(struct fsi_master_gpio *master, struct > > > fsi_gpio_msg *msg, > > > +   uint8_t num_bits) > > > +{ > > > +   uint8_t bit, in_bit; > > > + > > > +   set_sda_input(master); > > > +

Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master

2017-03-30 Thread Christopher Bostic
On 3/30/17 12:48 AM, Joel Stanley wrote: On Thu, Mar 30, 2017 at 4:13 AM, Christopher Bostic wrote: From: Chris Bostic Implement a FSI master using GPIO. Will generate FSI protocol for read and write commands to particular addresses. Sends master command and waits for and decodes a slave

Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master

2017-03-29 Thread Joel Stanley
On Thu, Mar 30, 2017 at 4:13 AM, Christopher Bostic wrote: > From: Chris Bostic > > Implement a FSI master using GPIO. Will generate FSI protocol for > read and write commands to particular addresses. Sends master command > and waits for and decodes a slave response. > > Includes changes from E

[PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master

2017-03-29 Thread Christopher Bostic
From: Chris Bostic Implement a FSI master using GPIO. Will generate FSI protocol for read and write commands to particular addresses. Sends master command and waits for and decodes a slave response. Includes changes from Edward A. James and Jeremy Kerr . Signed-off-by: Edward A. James Signe