Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-05 Thread Daniel Scally
Morning Kieran On 05/01/2021 06:55, Kieran Bingham wrote: > Hi Dan, > > On 04/01/2021 22:02, Daniel Scally wrote: >> On 04/01/2021 13:35, Kieran Bingham wrote: +/* + * Extend this array with ACPI Hardware IDs of devices known to be working + * plus the numb

Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-04 Thread Kieran Bingham
Hi Dan, On 04/01/2021 22:02, Daniel Scally wrote: > On 04/01/2021 13:35, Kieran Bingham wrote: >>> +/* >>> + * Extend this array with ACPI Hardware IDs of devices known to be >>> working >>> + * plus the number of link-frequencies expected by their drivers, >>> along with

Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-04 Thread Daniel Scally
Hi Kieran On 04/01/2021 16:13, Kieran Bingham wrote: > Hi Dan, > > On 04/01/2021 15:31, Daniel Scally wrote: >> Hi Kieran >> >> On 04/01/2021 15:13, Kieran Bingham wrote: >>> Hi Dan, >>> >>> On 04/01/2021 13:55, Daniel Scally wrote: Hi Kieran On 04/01/2021 13:35, Kieran Bingham wro

Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-04 Thread Kieran Bingham
Hi Dan, On 04/01/2021 15:31, Daniel Scally wrote: > Hi Kieran > > On 04/01/2021 15:13, Kieran Bingham wrote: >> Hi Dan, >> >> On 04/01/2021 13:55, Daniel Scally wrote: >>> Hi Kieran >>> >>> On 04/01/2021 13:35, Kieran Bingham wrote: > +/* > + * Extend this array with ACPI Hardware IDs of

Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-04 Thread Daniel Scally
Hi Kieran On 04/01/2021 15:13, Kieran Bingham wrote: > Hi Dan, > > On 04/01/2021 13:55, Daniel Scally wrote: >> Hi Kieran >> >> On 04/01/2021 13:35, Kieran Bingham wrote: +/* + * Extend this array with ACPI Hardware IDs of devices known to be working + * plus the number of link-freq

Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-04 Thread Kieran Bingham
Hi Dan, On 04/01/2021 13:55, Daniel Scally wrote: > Hi Kieran > > On 04/01/2021 13:35, Kieran Bingham wrote: >>> +/* >>> + * Extend this array with ACPI Hardware IDs of devices known to be working >>> + * plus the number of link-frequencies expected by their drivers, along >>> with >>> + * the f

Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-04 Thread Andy Shevchenko
On Mon, Jan 4, 2021 at 3:55 PM Daniel Scally wrote: > On 04/01/2021 13:35, Kieran Bingham wrote: ... > +static const struct cio2_sensor_config cio2_supported_sensors[] = { > + /* Sensor OVTI5693 */ > + CIO2_SENSOR_CONFIG("INT33BE", 0), > + /* Sensor OVTI2680 */ > + CIO2_S

Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-04 Thread Daniel Scally
On 04/01/2021 13:38, Andy Shevchenko wrote: > On Mon, Jan 4, 2021 at 3:02 PM Daniel Scally wrote: >> On 04/01/2021 12:09, Andy Shevchenko wrote: >>> On Sun, Jan 03, 2021 at 11:12:35PM +, Daniel Scally wrote: > ... > +#define NODE_SENSOR(_HID, _PROPS) \ +((const struct

Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-04 Thread Daniel Scally
Hi Kieran On 04/01/2021 13:35, Kieran Bingham wrote: >> +/* >> + * Extend this array with ACPI Hardware IDs of devices known to be working >> + * plus the number of link-frequencies expected by their drivers, along with >> + * the frequency values in hertz. This is somewhat opportunistic way of >

Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-04 Thread Andy Shevchenko
On Mon, Jan 4, 2021 at 3:02 PM Daniel Scally wrote: > On 04/01/2021 12:09, Andy Shevchenko wrote: > > On Sun, Jan 03, 2021 at 11:12:35PM +, Daniel Scally wrote: ... > >> +#define NODE_SENSOR(_HID, _PROPS) \ > >> +((const struct software_node) { \ > >> +.name

Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-04 Thread Kieran Bingham
Hi Dan, On 03/01/2021 23:12, Daniel Scally wrote: > Currently on platforms designed for Windows, connections between CIO2 and > sensors are not properly defined in DSDT. This patch extends the ipu3-cio2 > driver to compensate by building software_node connections, parsing the > connection properti

Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-04 Thread Daniel Scally
Hi Andy On 04/01/2021 12:09, Andy Shevchenko wrote: > On Sun, Jan 03, 2021 at 11:12:35PM +, Daniel Scally wrote: >> Currently on platforms designed for Windows, connections between CIO2 and >> sensors are not properly defined in DSDT. This patch extends the ipu3-cio2 >> driver to compensate by

Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-04 Thread Andy Shevchenko
On Sun, Jan 03, 2021 at 11:12:35PM +, Daniel Scally wrote: > Currently on platforms designed for Windows, connections between CIO2 and > sensors are not properly defined in DSDT. This patch extends the ipu3-cio2 > driver to compensate by building software_node connections, parsing the > connect

[PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-03 Thread Daniel Scally
Currently on platforms designed for Windows, connections between CIO2 and sensors are not properly defined in DSDT. This patch extends the ipu3-cio2 driver to compensate by building software_node connections, parsing the connection properties from the sensor's SSDB buffer. Suggested-by: Jordan Han