RE: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-22 Thread Yoshihiro Shimoda
Hi Matti-san, > From: Vaittinen, Matti, Sent: Tuesday, December 22, 2020 6:39 PM > > Also, I think I should remove the following patch. > > > > [PATCH v4 08/12] gpio: bd9571mwv: Add BD9574MWF support > > I think this depends on whether you wish to add support for the > > > "RECOV_GPOUT", "FREQS

RE: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-22 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 6:32 PM > > Also, I think I should remove the following patch. > > > > [PATCH v4 08/12] gpio: bd9571mwv: Add BD9574MWF support > > You mean removing the chip types from bd9571mwv_gpio_id_table[]? > You still need the "bd9

Re: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-22 Thread Vaittinen, Matti
On Tue, 2020-12-22 at 09:23 +, Yoshihiro Shimoda wrote: > Hi Geert-san, > > Thank you for your review! > > > From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 5:53 PM > > On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda > > wrote: > > > > --- a/drivers/mfd/bd9571mwv.c > > > +++ b

Re: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-22 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, Dec 22, 2020 at 10:23 AM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 5:53 PM > > On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda > > wrote: > > > > --- a/drivers/mfd/bd9571mwv.c > > > +++ b/drivers/mfd/bd9571mwv.c > > > > > @

RE: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-22 Thread Yoshihiro Shimoda
Hi Geert-san, Thank you for your review! > From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 5:53 PM > On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda > wrote: > > --- a/drivers/mfd/bd9571mwv.c > > +++ b/drivers/mfd/bd9571mwv.c > > > @@ -200,12 +277,14 @@ static int bd9571mwv_probe(

Re: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-22 Thread Geert Uytterhoeven
Hi Shimoda-san, On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda wrote: > From: Khiem Nguyen > > The new PMIC BD9574MWF inherits features from BD9571MWV. > Add the support of new PMIC to existing bd9571mwv driver. > > Signed-off-by: Khiem Nguyen > Co-developed-by: Yoshihiro Shimoda > Signed-o

[PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-20 Thread Yoshihiro Shimoda
From: Khiem Nguyen The new PMIC BD9574MWF inherits features from BD9571MWV. Add the support of new PMIC to existing bd9571mwv driver. Signed-off-by: Khiem Nguyen Co-developed-by: Yoshihiro Shimoda Signed-off-by: Yoshihiro Shimoda --- drivers/mfd/bd9571mwv.c | 83 +++