Re: [PATCH v4 10/10] powerpc/smp: Implement cpu_to_coregroup_id

2020-07-31 Thread Michael Ellerman
Srikar Dronamraju writes: > * Michael Ellerman [2020-07-31 18:02:21]: > >> Srikar Dronamraju writes: >> > Lookup the coregroup id from the associativity array. > > Thanks Michael for all your comments and inputs. > >> It's slightly strange that this is called in patch 9, but only properly >> imp

Re: [PATCH v4 10/10] powerpc/smp: Implement cpu_to_coregroup_id

2020-07-31 Thread Srikar Dronamraju
* Michael Ellerman [2020-07-31 18:02:21]: > Srikar Dronamraju writes: > > Lookup the coregroup id from the associativity array. > Thanks Michael for all your comments and inputs. > It's slightly strange that this is called in patch 9, but only properly > implemented here in patch 10. > > I'm

Re: [PATCH v4 10/10] powerpc/smp: Implement cpu_to_coregroup_id

2020-07-31 Thread Michael Ellerman
Srikar Dronamraju writes: > Lookup the coregroup id from the associativity array. It's slightly strange that this is called in patch 9, but only properly implemented here in patch 10. I'm not saying you have to squash them together, but it would be good if the change log for patch 9 mentioned th

[PATCH v4 10/10] powerpc/smp: Implement cpu_to_coregroup_id

2020-07-26 Thread Srikar Dronamraju
Lookup the coregroup id from the associativity array. If unable to detect the coregroup id, fallback on the core id. This way, ensure sched_domain degenerates and an extra sched domain is not created. Ideally this function should have been implemented in arch/powerpc/kernel/smp.c. However if its

[PATCH v4 10/10] powerpc/smp: Implement cpu_to_coregroup_id

2020-07-26 Thread Srikar Dronamraju
Lookup the coregroup id from the associativity array. If unable to detect the coregroup id, fallback on the core id. This way, ensure sched_domain degenerates and an extra sched domain is not created. Ideally this function should have been implemented in arch/powerpc/kernel/smp.c. However if its