Re: [PATCH v4 10/10] blk-mq: support per-distpatch_queue flush machinery

2014-09-24 Thread Ming Lei
On Wed, Sep 24, 2014 at 6:26 PM, Christoph Hellwig wrote: >> +struct blk_flush_queue *blk_alloc_flush_queue(struct request_queue *q, >> + struct blk_mq_hw_ctx *hctx, int cmd_size) > > I still think this should pass in the numa node instead of the hctx, and > allow node-local allocation

Re: [PATCH v4 10/10] blk-mq: support per-distpatch_queue flush machinery

2014-09-24 Thread Christoph Hellwig
> +struct blk_flush_queue *blk_alloc_flush_queue(struct request_queue *q, > + struct blk_mq_hw_ctx *hctx, int cmd_size) I still think this should pass in the numa node instead of the hctx, and allow node-local allocation for the old code as well. As mentioned earlier initializing mq_f

[PATCH v4 10/10] blk-mq: support per-distpatch_queue flush machinery

2014-09-15 Thread Ming Lei
This patch supports to run one single flush machinery for each blk-mq dispatch queue, so that: - current init_request and exit_request callbacks can cover flush request too, then the buggy copying way of initializing flush request's pdu can be fixed - flushing performance gets improved in case of