Re: [PATCH v4 1/5] uprobes, x86: Fix _TIF_UPROBE vs _TIF_NOTIFY_RESUME

2014-11-24 Thread Andy Lutomirski
On Sat, Nov 22, 2014 at 8:55 AM, Borislav Petkov wrote: > On Fri, Nov 21, 2014 at 01:26:07PM -0800, Andy Lutomirski wrote: >> x86 call do_notify_resume on paranoid returns if TIF_UPROBE is set >> but not on non-paranoid returns. I suspect that this is a mistake >> and that the code only works bec

Re: [PATCH v4 1/5] uprobes, x86: Fix _TIF_UPROBE vs _TIF_NOTIFY_RESUME

2014-11-22 Thread Borislav Petkov
On Fri, Nov 21, 2014 at 01:26:07PM -0800, Andy Lutomirski wrote: > x86 call do_notify_resume on paranoid returns if TIF_UPROBE is set > but not on non-paranoid returns. I suspect that this is a mistake > and that the code only works because int3 is paranoid. > > Setting _TIF_NOTIFY_RESUME in the

[PATCH v4 1/5] uprobes, x86: Fix _TIF_UPROBE vs _TIF_NOTIFY_RESUME

2014-11-21 Thread Andy Lutomirski
x86 call do_notify_resume on paranoid returns if TIF_UPROBE is set but not on non-paranoid returns. I suspect that this is a mistake and that the code only works because int3 is paranoid. Setting _TIF_NOTIFY_RESUME in the uprobe code was probably a workaround for the x86 bug. With that bug fixed