Re: [PATCH v4 1/5] platform/x86: intel_pmc_ipc: fix gcr offset

2017-04-04 Thread sathyanarayanan kuppuswamy
On 04/04/2017 06:25 AM, Andy Shevchenko wrote: Please, STOP top-posting. On Mon, Apr 3, 2017 at 4:51 AM, Sathyanarayanan Kuppuswamy Natarajan wrote: Yes, just applying this patch will fix the existing offset issue. Then the question how it was tested in both cases (before this change and no

Re: [PATCH v4 1/5] platform/x86: intel_pmc_ipc: fix gcr offset

2017-04-04 Thread Andy Shevchenko
Please, STOP top-posting. On Mon, Apr 3, 2017 at 4:51 AM, Sathyanarayanan Kuppuswamy Natarajan wrote: > Yes, just applying this patch will fix the existing offset issue. Then the question how it was tested in both cases (before this change and now) ? > > On Sun, Apr 2, 2017 at 7:11 AM, Andy She

Re: [PATCH v4 1/5] platform/x86: intel_pmc_ipc: fix gcr offset

2017-04-02 Thread Sathyanarayanan Kuppuswamy Natarajan
Yes, just applying this patch will fix the existing offset issue. On Sun, Apr 2, 2017 at 7:11 AM, Andy Shevchenko wrote: > On Sat, Apr 1, 2017 at 2:27 AM, Kuppuswamy Sathyanarayanan > wrote: >> According to Broxton APL PMC spec, gcr mem region starts >> at offset 0x1000 from ipc mem base address

Re: [PATCH v4 1/5] platform/x86: intel_pmc_ipc: fix gcr offset

2017-04-02 Thread Andy Shevchenko
On Sat, Apr 1, 2017 at 2:27 AM, Kuppuswamy Sathyanarayanan wrote: > According to Broxton APL PMC spec, gcr mem region starts > at offset 0x1000 from ipc mem base address. In this driver, > PLAT_RESOURCE_GCR_OFFSET macro defines the offset of GCR > memory region from IPC mem region. So we should us

[PATCH v4 1/5] platform/x86: intel_pmc_ipc: fix gcr offset

2017-03-31 Thread Kuppuswamy Sathyanarayanan
According to Broxton APL PMC spec, gcr mem region starts at offset 0x1000 from ipc mem base address. In this driver, PLAT_RESOURCE_GCR_OFFSET macro defines the offset of GCR memory region from IPC mem region. So we should use 0x1000(4K) as GCR offset. But currently this driver uses 0x1008 as GCT of