Re: [PATCH v4 1/4] fpga: dfl: change data type of feature id to u16

2020-08-27 Thread Xu Yilun
On Wed, Aug 19, 2020 at 09:14:31PM -0700, Moritz Fischer wrote: > On Thu, Aug 13, 2020 at 05:04:09PM +0800, Xu Yilun wrote: > > On Thu, Aug 13, 2020 at 08:28:05AM +, David Laight wrote: > > > From: Xu Yilun > > > > Sent: 13 August 2020 08:59 > > > > On Wed, Aug 12, 2020 at 08:52:39AM +, Dav

Re: [PATCH v4 1/4] fpga: dfl: change data type of feature id to u16

2020-08-19 Thread Moritz Fischer
On Thu, Aug 13, 2020 at 05:04:09PM +0800, Xu Yilun wrote: > On Thu, Aug 13, 2020 at 08:28:05AM +, David Laight wrote: > > From: Xu Yilun > > > Sent: 13 August 2020 08:59 > > > On Wed, Aug 12, 2020 at 08:52:39AM +, David Laight wrote: > > > > From: Moritz Fischer > > > > > Sent: 12 August 20

RE: [PATCH v4 1/4] fpga: dfl: change data type of feature id to u16

2020-08-13 Thread David Laight
From: Xu Yilun > Sent: 13 August 2020 10:04 > > On Thu, Aug 13, 2020 at 08:28:05AM +, David Laight wrote: > > From: Xu Yilun > > > Sent: 13 August 2020 08:59 > > > On Wed, Aug 12, 2020 at 08:52:39AM +, David Laight wrote: > > > > From: Moritz Fischer > > > > > Sent: 12 August 2020 04:56 >

Re: [PATCH v4 1/4] fpga: dfl: change data type of feature id to u16

2020-08-13 Thread Xu Yilun
On Thu, Aug 13, 2020 at 08:28:05AM +, David Laight wrote: > From: Xu Yilun > > Sent: 13 August 2020 08:59 > > On Wed, Aug 12, 2020 at 08:52:39AM +, David Laight wrote: > > > From: Moritz Fischer > > > > Sent: 12 August 2020 04:56 > > > > > > > > On Mon, Aug 10, 2020 at 10:41:10AM +0800, Xu

RE: [PATCH v4 1/4] fpga: dfl: change data type of feature id to u16

2020-08-13 Thread David Laight
From: Xu Yilun > Sent: 13 August 2020 08:59 > On Wed, Aug 12, 2020 at 08:52:39AM +, David Laight wrote: > > From: Moritz Fischer > > > Sent: 12 August 2020 04:56 > > > > > > On Mon, Aug 10, 2020 at 10:41:10AM +0800, Xu Yilun wrote: > > > > The feature id is stored in a 12 bit field in DFH. So a

Re: [PATCH v4 1/4] fpga: dfl: change data type of feature id to u16

2020-08-13 Thread Xu Yilun
On Wed, Aug 12, 2020 at 08:52:39AM +, David Laight wrote: > From: Moritz Fischer > > Sent: 12 August 2020 04:56 > > > > On Mon, Aug 10, 2020 at 10:41:10AM +0800, Xu Yilun wrote: > > > The feature id is stored in a 12 bit field in DFH. So a u16 variable is > > > enough for feature id. > > > > >

RE: [PATCH v4 1/4] fpga: dfl: change data type of feature id to u16

2020-08-12 Thread David Laight
From: Moritz Fischer > Sent: 12 August 2020 04:56 > > On Mon, Aug 10, 2020 at 10:41:10AM +0800, Xu Yilun wrote: > > The feature id is stored in a 12 bit field in DFH. So a u16 variable is > > enough for feature id. > > > > This patch changes all feature id related places to fit u16. How much bigg

Re: [PATCH v4 1/4] fpga: dfl: change data type of feature id to u16

2020-08-11 Thread Moritz Fischer
On Mon, Aug 10, 2020 at 10:41:10AM +0800, Xu Yilun wrote: > The feature id is stored in a 12 bit field in DFH. So a u16 variable is > enough for feature id. > > This patch changes all feature id related places to fit u16. > > Signed-off-by: Xu Yilun > Reviewed-by: Tom Rix > Acked-by: Wu Hao >

[PATCH v4 1/4] fpga: dfl: change data type of feature id to u16

2020-08-09 Thread Xu Yilun
The feature id is stored in a 12 bit field in DFH. So a u16 variable is enough for feature id. This patch changes all feature id related places to fit u16. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix Acked-by: Wu Hao --- v3: no change. v4: no change. --- drivers/fpga/dfl-fme-perf.c | 2 +-