Re: [PATCH v4 1/3] PM / Hibernate: prepare for SANITIZE_FREED_PAGES

2015-05-20 Thread Rafael J. Wysocki
On Wednesday, May 20, 2015 02:07:36 PM Anisse Astier wrote: > On Wed, May 20, 2015 at 1:45 PM, PaX Team wrote: > > > >> Moreover, why is the resume code path the only one where freed pages need > >> to > >> be sanitized? > > > > ... i had a bug report before > > (http://marc.info/?l=linux-pm&m=1

Re: [PATCH v4 1/3] PM / Hibernate: prepare for SANITIZE_FREED_PAGES

2015-05-20 Thread Anisse Astier
On Wed, May 20, 2015 at 1:45 PM, PaX Team wrote: > >> Moreover, why is the resume code path the only one where freed pages need to >> be sanitized? > > ... i had a bug report before (http://marc.info/?l=linux-pm&m=132871433416256) > which is why i asked Anisse to figure this out before upstreaming

Re: [PATCH v4 1/3] PM / Hibernate: prepare for SANITIZE_FREED_PAGES

2015-05-20 Thread Anisse Astier
On Wed, May 20, 2015 at 1:46 AM, Rafael J. Wysocki wrote: > On Monday, May 18, 2015 12:23:00 PM Anisse Astier wrote: >> Hi Rafael, >> >> Thanks for taking the time to review this. >> >> On Sat, May 16, 2015 at 2:28 AM, Rafael J. Wysocki >> wrote: >> > On Thursday, May 14, 2015 04:19:46 PM Anisse

Re: [PATCH v4 1/3] PM / Hibernate: prepare for SANITIZE_FREED_PAGES

2015-05-20 Thread PaX Team
On 20 May 2015 at 1:46, Rafael J. Wysocki wrote: > swsusp_free() is *the* function that, well, frees all the pages allocated > by the hibernate core, so how isn't the free pages bitmap valid when it is > called? > > Why don't you add the clearing in there, right at the spot when the pages > are a

Re: [PATCH v4 1/3] PM / Hibernate: prepare for SANITIZE_FREED_PAGES

2015-05-19 Thread Rafael J. Wysocki
On Monday, May 18, 2015 12:23:00 PM Anisse Astier wrote: > Hi Rafael, > > Thanks for taking the time to review this. > > On Sat, May 16, 2015 at 2:28 AM, Rafael J. Wysocki wrote: > > On Thursday, May 14, 2015 04:19:46 PM Anisse Astier wrote: > >> SANITIZE_FREED_PAGES feature relies on having all

Re: [PATCH v4 1/3] PM / Hibernate: prepare for SANITIZE_FREED_PAGES

2015-05-18 Thread Anisse Astier
Hi Rafael, Thanks for taking the time to review this. On Sat, May 16, 2015 at 2:28 AM, Rafael J. Wysocki wrote: > On Thursday, May 14, 2015 04:19:46 PM Anisse Astier wrote: >> SANITIZE_FREED_PAGES feature relies on having all pages going through >> the free_pages_prepare path in order to be clea

Re: [PATCH v4 1/3] PM / Hibernate: prepare for SANITIZE_FREED_PAGES

2015-05-15 Thread Rafael J. Wysocki
On Thursday, May 14, 2015 04:19:46 PM Anisse Astier wrote: > SANITIZE_FREED_PAGES feature relies on having all pages going through > the free_pages_prepare path in order to be cleared before being used. In > the hibernate use case, free pages will automagically appear in the > system without being

[PATCH v4 1/3] PM / Hibernate: prepare for SANITIZE_FREED_PAGES

2015-05-14 Thread Anisse Astier
SANITIZE_FREED_PAGES feature relies on having all pages going through the free_pages_prepare path in order to be cleared before being used. In the hibernate use case, free pages will automagically appear in the system without being cleared, left there by the loading kernel. This patch will make su