Re: [PATCH v4 1/3] PCI/IOV: Mark VFs as not implementing MSE bit

2020-09-09 Thread Bjorn Helgaas
On Thu, Sep 03, 2020 at 01:10:02PM -0400, Matthew Rosato wrote: > On 9/3/20 12:41 PM, Bjorn Helgaas wrote: > >- How do we decide whether to use dev_flags vs a bitfield like > > dev->is_virtfn? The latter seems simpler unless there's a reason > > to use dev_flags. If there's a reaso

Re: [PATCH v4 1/3] PCI/IOV: Mark VFs as not implementing MSE bit

2020-09-09 Thread Alex Williamson
On Thu, 3 Sep 2020 13:10:02 -0400 Matthew Rosato wrote: > On 9/3/20 12:41 PM, Bjorn Helgaas wrote: > > On Wed, Sep 02, 2020 at 03:46:34PM -0400, Matthew Rosato wrote: > >> Per the PCIe spec, VFs cannot implement the MSE bit > >> AKA PCI_COMMAND_MEMORY, and it must be hard-wired to 0. > >> Use a

Re: [PATCH v4 1/3] PCI/IOV: Mark VFs as not implementing MSE bit

2020-09-03 Thread Matthew Rosato
On 9/3/20 12:41 PM, Bjorn Helgaas wrote: On Wed, Sep 02, 2020 at 03:46:34PM -0400, Matthew Rosato wrote: Per the PCIe spec, VFs cannot implement the MSE bit AKA PCI_COMMAND_MEMORY, and it must be hard-wired to 0. Use a dev_flags bit to signify this requirement. This approach seems sensible to

Re: [PATCH v4 1/3] PCI/IOV: Mark VFs as not implementing MSE bit

2020-09-03 Thread Bjorn Helgaas
On Wed, Sep 02, 2020 at 03:46:34PM -0400, Matthew Rosato wrote: > Per the PCIe spec, VFs cannot implement the MSE bit > AKA PCI_COMMAND_MEMORY, and it must be hard-wired to 0. > Use a dev_flags bit to signify this requirement. This approach seems sensible to me, but - This is confusing because

[PATCH v4 1/3] PCI/IOV: Mark VFs as not implementing MSE bit

2020-09-02 Thread Matthew Rosato
Per the PCIe spec, VFs cannot implement the MSE bit AKA PCI_COMMAND_MEMORY, and it must be hard-wired to 0. Use a dev_flags bit to signify this requirement. Signed-off-by: Matthew Rosato --- drivers/pci/iov.c | 1 + include/linux/pci.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/dri