Re: [PATCH v4 1/2] leds: core: Introduce LED pattern trigger

2018-08-06 Thread Baolin Wang
Hi Jacek, On 6 August 2018 at 19:41, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/06/2018 03:53 AM, Baolin Wang wrote: >> Hi Jacek, > [...] +++ b/Documentation/ABI/testing/sysfs-class-led-trigger-pattern @@ -0,0 +1,21 @@ +What:/sys/class/leds//pattern +Date:

Re: [PATCH v4 1/2] leds: core: Introduce LED pattern trigger

2018-08-06 Thread Jacek Anaszewski
Hi Baolin, On 08/06/2018 03:53 AM, Baolin Wang wrote: > Hi Jacek, [...] >>> +++ b/Documentation/ABI/testing/sysfs-class-led-trigger-pattern >>> @@ -0,0 +1,21 @@ >>> +What:/sys/class/leds//pattern >>> +Date:August 2018 >>> +KernelVersion: 4.19 >>> +Description:

Re: [PATCH v4 1/2] leds: core: Introduce LED pattern trigger

2018-08-06 Thread Baolin Wang
On 6 August 2018 at 16:06, Pavel Machek wrote: > On Mon 2018-08-06 15:33:12, Baolin Wang wrote: >> Hi Pavel, >> >> On 6 August 2018 at 15:09, Pavel Machek wrote: >> > Hi! >> > >> >> > In current implementation this file on read returns the number >> >> > of remaining repeat intervals. I'd add tha

Re: [PATCH v4 1/2] leds: core: Introduce LED pattern trigger

2018-08-06 Thread Pavel Machek
On Mon 2018-08-06 15:33:12, Baolin Wang wrote: > Hi Pavel, > > On 6 August 2018 at 15:09, Pavel Machek wrote: > > Hi! > > > >> > In current implementation this file on read returns the number > >> > of remaining repeat intervals. I'd add that to this description. > >> > >> I saw Pavel's comments

Re: [PATCH v4 1/2] leds: core: Introduce LED pattern trigger

2018-08-06 Thread Baolin Wang
Hi Pavel, On 6 August 2018 at 15:09, Pavel Machek wrote: > Hi! > >> > In current implementation this file on read returns the number >> > of remaining repeat intervals. I'd add that to this description. >> >> I saw Pavel's comments that he did not suggest do this. So I will keep >> the original d

Re: [PATCH v4 1/2] leds: core: Introduce LED pattern trigger

2018-08-06 Thread Pavel Machek
Hi! > > In current implementation this file on read returns the number > > of remaining repeat intervals. I'd add that to this description. > > I saw Pavel's comments that he did not suggest do this. So I will keep > the original description? If that is accepted, the code should return originall

Re: [PATCH v4 1/2] leds: core: Introduce LED pattern trigger

2018-08-05 Thread Baolin Wang
Hi Jacek, On 6 August 2018 at 00:10, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the fix. > > I've found few more details to improve, please take a look > at my comments below. > > On 08/05/2018 06:04 AM, Baolin Wang wrote: >> Some LED controllers have support for autonomously controll

Re: [PATCH v4 1/2] leds: core: Introduce LED pattern trigger

2018-08-05 Thread Pavel Machek
Hi! > > +What: /sys/class/leds//repeat > > +Date: August 2018 > > +KernelVersion: 4.19 > > +Description: > > + Specify a pattern repeat number. 0 means repeat indefinitely. > > In current implementation this file on read returns the number > of remaining re

Re: [PATCH v4 1/2] leds: core: Introduce LED pattern trigger

2018-08-05 Thread Jacek Anaszewski
Hi Baolin, Thank you for the fix. I've found few more details to improve, please take a look at my comments below. On 08/05/2018 06:04 AM, Baolin Wang wrote: > Some LED controllers have support for autonomously controlling > brightness over time, according to some preprogrammed pattern or > func

[PATCH v4 1/2] leds: core: Introduce LED pattern trigger

2018-08-04 Thread Baolin Wang
Some LED controllers have support for autonomously controlling brightness over time, according to some preprogrammed pattern or function. This patch adds pattern trigger that LED device can configure the pattern and trigger it. Signed-off-by: Raphael Teysseyre Signed-off-by: Baolin Wang --- Cha