Re: [PATCH v4 1/2] i2c: qup: add ACPI support

2016-07-01 Thread Arnd Bergmann
On Thursday, June 30, 2016 2:50:44 PM CEST Christopher Covington wrote: > Hi Arnd, > > On 06/30/2016 07:52 AM, Arnd Bergmann wrote: > > On Thursday, June 30, 2016 7:35:14 AM CEST Christopher Covington wrote: > >> Hi Arnd, > >> > >> On 06/08/2016 05:02 PM, Arnd Bergmann wrote: > >>> On Wednesday, J

Re: [PATCH v4 1/2] i2c: qup: add ACPI support

2016-06-30 Thread Christopher Covington
Hi Arnd, On 06/30/2016 07:52 AM, Arnd Bergmann wrote: > On Thursday, June 30, 2016 7:35:14 AM CEST Christopher Covington wrote: >> Hi Arnd, >> >> On 06/08/2016 05:02 PM, Arnd Bergmann wrote: >>> On Wednesday, June 8, 2016 12:19:44 PM CEST Austin Christ wrote: + ret = device_prop

Re: [PATCH v4 1/2] i2c: qup: add ACPI support

2016-06-30 Thread Arnd Bergmann
On Thursday, June 30, 2016 7:35:14 AM CEST Christopher Covington wrote: > Hi Arnd, > > On 06/08/2016 05:02 PM, Arnd Bergmann wrote: > > On Wednesday, June 8, 2016 12:19:44 PM CEST Austin Christ wrote: > >> + ret = device_property_read_u32(qup->dev, > >> +

Re: [PATCH v4 1/2] i2c: qup: add ACPI support

2016-06-30 Thread Christopher Covington
Hi Arnd, On 06/08/2016 05:02 PM, Arnd Bergmann wrote: > On Wednesday, June 8, 2016 12:19:44 PM CEST Austin Christ wrote: >> + ret = device_property_read_u32(qup->dev, >> + "src-clock-hz", &src_clk_freq); >> + if (ret) { >> +

Re: [PATCH v4 1/2] i2c: qup: add ACPI support

2016-06-20 Thread Mika Westerberg
On Mon, Jun 20, 2016 at 10:00:46AM -0500, Timur Tabi wrote: > Mika Westerberg wrote: > > Use has_acpi_companion() if you need to. > > Is has_acpi_companion() the preferred alternative to ACPI_HANDLE()? We > frequently need to write code that does something different on ACPI vs DT, > and there doe

Re: [PATCH v4 1/2] i2c: qup: add ACPI support

2016-06-20 Thread Timur Tabi
Mika Westerberg wrote: Use has_acpi_companion() if you need to. Is has_acpi_companion() the preferred alternative to ACPI_HANDLE()? We frequently need to write code that does something different on ACPI vs DT, and there doesn't appear to be much consistency on how that's handled. -- Sent b

Re: [PATCH v4 1/2] i2c: qup: add ACPI support

2016-06-20 Thread Mika Westerberg
On Sat, Jun 18, 2016 at 04:10:34PM +0200, Wolfram Sang wrote: > On Wed, Jun 08, 2016 at 12:19:44PM -0600, Austin Christ wrote: > > From: Naveen Kaje > > > > Add support to get the device parameters from ACPI. Assume > > that the clocks are managed by firmware. > > Adding Mika to CC: Can you have

Re: [PATCH v4 1/2] i2c: qup: add ACPI support

2016-06-18 Thread Wolfram Sang
On Wed, Jun 08, 2016 at 12:19:44PM -0600, Austin Christ wrote: > From: Naveen Kaje > > Add support to get the device parameters from ACPI. Assume > that the clocks are managed by firmware. Adding Mika to CC: Can you have a look at the ACPI binding? Looks ok to me... > > Signed-off-by: Naveen K

Re: [PATCH v4 1/2] i2c: qup: add ACPI support

2016-06-09 Thread kbuild test robot
Hi, [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v4.7-rc2 next-20160609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Austin-Christ/i2c-qup-add-ACPI-support/20160609-0

Re: [PATCH v4 1/2] i2c: qup: add ACPI support

2016-06-08 Thread Arnd Bergmann
On Wednesday, June 8, 2016 12:19:44 PM CEST Austin Christ wrote: > + ret = device_property_read_u32(qup->dev, > + "src-clock-hz", &src_clk_freq); > + if (ret) { > + dev_warn(qup->dev, "using default src-clock-hz %d", >

[PATCH v4 1/2] i2c: qup: add ACPI support

2016-06-08 Thread Austin Christ
From: Naveen Kaje Add support to get the device parameters from ACPI. Assume that the clocks are managed by firmware. Signed-off-by: Naveen Kaje Signed-off-by: Austin Christ Reviewed-by: sricha...@codeaurora.org --- drivers/i2c/busses/i2c-qup.c | 59 ---