Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

On Tue, Jan 23, 2018 at 11:44:59AM +0100, Mylene Josserand wrote: > Hi Dmitry, > > Thank you for the review. > > Le Mon, 22 Jan 2018 20:15:03 -0800, > Dmitry Torokhov a écrit : > > > Hi Mylène, > > > > On Fri, Dec 01, 2017 at 04:39:56PM +0100, Mylène Josserand wrote: > > > This is the basic dr

Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hey, thanks for the great work on this one! Best regards On 01/23/2018 11:44 AM, Mylene Josserand wrote: Hi Dmitry, Thank you for the review. Le Mon, 22 Jan 2018 20:15:03 -0800, Dmitry Torokhov a écrit : Hi Mylène, On Fri, Dec 01, 2017 at 04:39:56PM +0100, Mylène Josserand wrote: This i

Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hi Dmitry, Thank you for the review. Le Mon, 22 Jan 2018 20:15:03 -0800, Dmitry Torokhov a écrit : > Hi Mylène, > > On Fri, Dec 01, 2017 at 04:39:56PM +0100, Mylène Josserand wrote: > > This is the basic driver for the Cypress TrueTouch Gen5 touchscreen > > controllers. This driver supports on

Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hello Marcus, Thank you for the review. Le Mon, 22 Jan 2018 21:11:09 +0100, Marcus Folkesson a écrit : > Mylene, > > On Fri, Dec 01, 2017 at 04:39:56PM +0100, Mylène Josserand wrote: > > +++ b/drivers/input/touchscreen/cyttsp5.c > > @@ -0,0 +1,1110 @@ > > +/* > > + * Parade TrueTouch(TM) Stand

Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hi Mylène, On Fri, Dec 01, 2017 at 04:39:56PM +0100, Mylène Josserand wrote: > This is the basic driver for the Cypress TrueTouch Gen5 touchscreen > controllers. This driver supports only the I2C bus but it uses regmap > so SPI support could be added later. > The touchscreen can retrieve some defi

Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Mylene, On Fri, Dec 01, 2017 at 04:39:56PM +0100, Mylène Josserand wrote: > +++ b/drivers/input/touchscreen/cyttsp5.c > @@ -0,0 +1,1110 @@ > +/* > + * Parade TrueTouch(TM) Standard Product V5 Module. > + * For use with Parade touchscreen controllers. > + * > + * Copyright (C) 2015 Parade Technolog

Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Dmitry, On Fri, Dec 01, 2017 at 04:39:56PM +0100, Mylène Josserand wrote: > This is the basic driver for the Cypress TrueTouch Gen5 touchscreen > controllers. This driver supports only the I2C bus but it uses regmap > so SPI support could be added later. > The touchscreen can retrieve some defined

Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hi Mylène, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on input/next] [also build test WARNING on v4.15-rc3 next-20171213] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/l

Re: [PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

Hi Mylène, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on input/next] [also build test WARNING on v4.15-rc1 next-20171201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/l

[PATCH v4 1/2] Input: Add driver for Cypress Generation 5 touchscreen

This is the basic driver for the Cypress TrueTouch Gen5 touchscreen controllers. This driver supports only the I2C bus but it uses regmap so SPI support could be added later. The touchscreen can retrieve some defined zone that are handled as buttons (according to the hardware). That is why it handl