Re: [RESEND][PATCH v4 1/2] Added AMS tsl2591 driver implementation

2021-03-08 Thread Joe Sandom
Thanks for the feedback Andy, just finishing up V5 with the majority of your comments on board. Some points of clarification inline. On Mon, Mar 01, 2021 at 01:49:49PM +0200, Andy Shevchenko wrote: > On Sat, Feb 27, 2021 at 6:58 PM Jonathan Cameron wrote: > > On Mon, 22 Feb 2021 21:23:12 + >

Re: [RESEND][PATCH v4 1/2] Added AMS tsl2591 driver implementation

2021-03-01 Thread Andy Shevchenko
On Sat, Feb 27, 2021 at 6:58 PM Jonathan Cameron wrote: > On Mon, 22 Feb 2021 21:23:12 + > Joe Sandom wrote: I will give my review on top of Jonathan's ones. ... > > Datasheet Available at: https://ams.com/tsl25911 Can we use Datasheet tag, please? Datasheet: > > ...and drop this blan

Re: [RESEND][PATCH v4 1/2] Added AMS tsl2591 driver implementation

2021-02-27 Thread Jonathan Cameron
On Mon, 22 Feb 2021 21:23:12 + Joe Sandom wrote: > Driver implementation for AMS/TAOS tsl2591 ambient light sensor. > > This driver supports configuration via device tree and sysfs. > Supported channels for raw infrared light intensity, > raw combined light intensity and illuminance in lux.

[RESEND][PATCH v4 1/2] Added AMS tsl2591 driver implementation

2021-02-22 Thread Joe Sandom
Driver implementation for AMS/TAOS tsl2591 ambient light sensor. This driver supports configuration via device tree and sysfs. Supported channels for raw infrared light intensity, raw combined light intensity and illuminance in lux. The driver additionally supports iio events on lower and upper th

[PATCH v4 1/2] Added AMS tsl2591 driver implementation

2021-02-22 Thread Joe Sandom
Driver implementation for AMS/TAOS tsl2591 ambient light sensor. This driver supports configuration via device tree and sysfs. Supported channels for raw infrared light intensity, raw combined light intensity and illuminance in lux. The driver additionally supports iio events on lower and upper th