Re: [PATCH v4 1/2] Add the driver of mbigen interrupt controller

2015-09-28 Thread Marc Zyngier
On 25/09/15 12:56, majun (F) wrote: > > > 在 2015/9/25 3:30, Marc Zyngier 写道: >> On Wed, 23 Sep 2015 15:24:50 +0800 >> "majun (F)" wrote: >> >> [...] >> > +static int mbigen_device_init(struct mbigen_chip *chip, > + struct device_node *node) > [...] > + > +co

Re: [PATCH v4 1/2] Add the driver of mbigen interrupt controller

2015-09-25 Thread majun (F)
在 2015/9/25 3:30, Marc Zyngier 写道: > On Wed, 23 Sep 2015 15:24:50 +0800 > "majun (F)" wrote: > > [...] > +static int mbigen_device_init(struct mbigen_chip *chip, + struct device_node *node) [...] + +core_initcall(mbigen_init); >>> >>> That's the wrong

Re: [PATCH v4 1/2] Add the driver of mbigen interrupt controller

2015-09-24 Thread Marc Zyngier
On Wed, 23 Sep 2015 15:24:50 +0800 "majun (F)" wrote: [...] > >> +static int mbigen_device_init(struct mbigen_chip *chip, > >> + struct device_node *node) > >> +{ > >> + struct mbigen_device *mgn_dev; > >> + struct device_node *msi_np; > >> + struct irq_do

Re: [PATCH v4 1/2] Add the driver of mbigen interrupt controller

2015-09-23 Thread majun (F)
Hi Marc: Thanks for reviewing this huge patch. 在 2015/9/22 5:53, Marc Zyngier 写道: > On Wed, 19 Aug 2015 03:55:19 +0100 > MaJun wrote: > >> From: Ma Jun >> [...] >> + * hwirq[32:12]: did. device id >> + * hwirq[11:8]: nid. mbigen node number >> + * hwirq[7:0]: pin. hardware pin offset of

Re: [PATCH v4 1/2] Add the driver of mbigen interrupt controller

2015-09-21 Thread Marc Zyngier
On Wed, 19 Aug 2015 03:55:19 +0100 MaJun wrote: > From: Ma Jun > > Mbigen means Message Based Interrupt Generator(MBIGEN). > > Its a kind of interrupt controller that collects > > the interrupts from external devices and generate msi interrupt. > > Mbigen is applied to reduce the number of w

Re: [PATCH v4 1/2] Add the driver of mbigen interrupt controller

2015-09-06 Thread majun (F)
Hi Alexey: 在 2015/9/4 8:56, Alexey Klimov 写道: > Hi Ma Jun, > > On Tue, Sep 1, 2015 at 4:45 AM, majun (F) wrote: >> Hi Alexey: >> [...] + mgn_chip->base = base; + mgn_chip->node = node; + + domain = irq_domain_add_tree(node, &mbigen_domain_ops, mgn_chip); >>>

Re: [PATCH v4 1/2] Add the driver of mbigen interrupt controller

2015-09-03 Thread Alexey Klimov
Hi Ma Jun, On Tue, Sep 1, 2015 at 4:45 AM, majun (F) wrote: > Hi Alexey: > > 在 2015/8/29 11:13, Alexey Klimov 写道: [..] >>> +*/ >>> +static u32 calc_irq_index(struct mbigen_device *dev, u32 nid, u32 offset) >>> +{ >>> + struct mbigen_node *mgn_node = NULL, *tmp; >>> + unsigned long f

Re: [PATCH v4 1/2] Add the driver of mbigen interrupt controller

2015-08-31 Thread majun (F)
Hi Alexey: 在 2015/8/29 11:13, Alexey Klimov 写道: > Hi Ma Jun, > > On Wed, Aug 19, 2015 at 5:55 AM, MaJun wrote: >> From: Ma Jun >> >> Mbigen means Message Based Interrupt Generator(MBIGEN). >> >> Its a kind of interrupt controller that collects >> >> the interrupts from external devices and gene

Re: [PATCH v4 1/2] Add the driver of mbigen interrupt controller

2015-08-28 Thread Alexey Klimov
Hi Ma Jun, On Wed, Aug 19, 2015 at 5:55 AM, MaJun wrote: > From: Ma Jun > > Mbigen means Message Based Interrupt Generator(MBIGEN). > > Its a kind of interrupt controller that collects > > the interrupts from external devices and generate msi interrupt. > > Mbigen is applied to reduce the number

[PATCH v4 1/2] Add the driver of mbigen interrupt controller

2015-08-18 Thread MaJun
From: Ma Jun Mbigen means Message Based Interrupt Generator(MBIGEN). Its a kind of interrupt controller that collects the interrupts from external devices and generate msi interrupt. Mbigen is applied to reduce the number of wire connected interrupts. As the peripherals increasing, the interr