Re: [PATCH v4 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

On 4/8/21 9:20 PM, Guenter Roeck wrote: > On 4/8/21 3:53 PM, Frank Rowand wrote: >> On 4/8/21 4:54 PM, Guenter Roeck wrote: >>> On 4/8/21 2:28 PM, Rob Herring wrote: Applying now so this gets into linux-next this week. >>> The patch doesn't apply on top of today's -next; it conflicts

Re: [PATCH v4 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

On 4/8/21 3:53 PM, Frank Rowand wrote: > On 4/8/21 4:54 PM, Guenter Roeck wrote: >> On 4/8/21 2:28 PM, Rob Herring wrote: >>> >>> Applying now so this gets into linux-next this week. >>> >> The patch doesn't apply on top of today's -next; it conflicts >> with "of: properly check for error returned

Re: [PATCH v4 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

On 4/8/21 4:54 PM, Guenter Roeck wrote: > On 4/8/21 2:28 PM, Rob Herring wrote: >> >> Applying now so this gets into linux-next this week. >> > The patch doesn't apply on top of today's -next; it conflicts > with "of: properly check for error returned by fdt_get_name()". > > I reverted that patch

Re: [PATCH v4 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

On 4/8/21 4:28 PM, Rob Herring wrote: > On Thu, Apr 8, 2021 at 3:45 PM wrote: >> >> From: Frank Rowand >> >> The Devicetree standard specifies an 8 byte alignment of the FDT. >> Code in libfdt expects this alignment for an FDT image in memory. >> kmemdup() returns 4 byte alignment on openrisc. R

Re: [PATCH v4 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

On 4/8/21 2:28 PM, Rob Herring wrote: > > Applying now so this gets into linux-next this week. > The patch doesn't apply on top of today's -next; it conflicts with "of: properly check for error returned by fdt_get_name()". I reverted that patch and applied this one, and the DT unittests run with

Re: [PATCH v4 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

On Thu, Apr 8, 2021 at 3:45 PM wrote: > > From: Frank Rowand > > The Devicetree standard specifies an 8 byte alignment of the FDT. > Code in libfdt expects this alignment for an FDT image in memory. > kmemdup() returns 4 byte alignment on openrisc. Replace kmemdup() > with kmalloc(), align point

[PATCH v4 1/1] of: unittest: overlay: ensure proper alignment of copied FDT

From: Frank Rowand The Devicetree standard specifies an 8 byte alignment of the FDT. Code in libfdt expects this alignment for an FDT image in memory. kmemdup() returns 4 byte alignment on openrisc. Replace kmemdup() with kmalloc(), align pointer, memcpy() to get proper alignment. The 4 byte al