Re: [PATCH v4 1/1] nvme: trace: add disk name to tracepoints

2018-06-26 Thread Sagi Grimberg
You want to submit or should I? Whatever is easier for you You're the owner, you should go ahead with it. Thanks!

Re: [PATCH v4 1/1] nvme: trace: add disk name to tracepoints

2018-06-26 Thread Johannes Thumshirn
On Tue, Jun 26, 2018 at 01:59:00PM +0300, Sagi Grimberg wrote: > You want to submit or should I? Whatever is easier for you -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90

Re: [PATCH v4 1/1] nvme: trace: add disk name to tracepoints

2018-06-26 Thread Sagi Grimberg
Looks good (both #1 if we want to use the two patch version or #2). I have no idea what I did when I was trying to do when I tried it. You want to submit or should I?

Re: [PATCH v4 1/1] nvme: trace: add disk name to tracepoints

2018-06-25 Thread Johannes Thumshirn
On Mon, Jun 25, 2018 at 04:31:28PM +0300, Sagi Grimberg wrote: > > > On 06/25/2018 10:08 AM, Johannes Thumshirn wrote: > > On Tue, Jun 19, 2018 at 05:09:27PM +0300, Sagi Grimberg wrote: > > > We are going to need it for traffic based keep alive to update > > > that we saw a completion to extend t

Re: [PATCH v4 1/1] nvme: trace: add disk name to tracepoints

2018-06-25 Thread Sagi Grimberg
On 06/25/2018 10:08 AM, Johannes Thumshirn wrote: On Tue, Jun 19, 2018 at 05:09:27PM +0300, Sagi Grimberg wrote: We are going to need it for traffic based keep alive to update that we saw a completion to extend the kato. But I suggest you simply keep a ctrl reference in struct nvme_request i

Re: [PATCH v4 1/1] nvme: trace: add disk name to tracepoints

2018-06-25 Thread Johannes Thumshirn
On Tue, Jun 19, 2018 at 05:09:27PM +0300, Sagi Grimberg wrote: > We are going to need it for traffic based keep alive to update > that we saw a completion to extend the kato. > > But I suggest you simply keep a ctrl reference in struct nvme_request > instead so you don't need to pass it to nvme_co

Re: [PATCH v4 1/1] nvme: trace: add disk name to tracepoints

2018-06-19 Thread Sagi Grimberg
On 06/11/2018 09:46 PM, Johannes Thumshirn wrote: Add disk name to tracepoints so we can better distinguish between individual disks in the trace output. Signed-off-by: Johannes Thumshirn --- I'm not entirely sure if this adding the ctrl pointers to nvme_complete_rq() and nvme_setup_cmd()

[PATCH v4 1/1] nvme: trace: add disk name to tracepoints

2018-06-11 Thread Johannes Thumshirn
Add disk name to tracepoints so we can better distinguish between individual disks in the trace output. Signed-off-by: Johannes Thumshirn --- I'm not entirely sure if this adding the ctrl pointers to nvme_complete_rq() and nvme_setup_cmd() is a good idea, it's the fast-path after all. Changes