Re: [alsa-devel] [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

2019-01-02 Thread Pierre-Louis Bossart
Please check out this tag next-20181224 and apply the patches afterwards. Thanks, will do. I think this patchset will uncover additional inconsistencies, e.g. for legacy Haswell/Broadwell/Baytrail the machine drivers depend on X86_INTEL_LPSS, which depends in turn on PCI, but the platform dr

Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

2019-01-02 Thread Rafael J. Wysocki
On Wed, Jan 2, 2019 at 10:34 AM Rafael J. Wysocki wrote: > > On Sun, Dec 30, 2018 at 8:56 PM Sinan Kaya wrote: > > > > Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on > > CONFIG_PCI set but this is not specified anywhere. > > IMO it would be better to say > > "After commit

Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

2019-01-02 Thread Rafael J. Wysocki
On Sun, Dec 30, 2018 at 8:56 PM Sinan Kaya wrote: > > Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on > CONFIG_PCI set but this is not specified anywhere. IMO it would be better to say "After commit 5d32a66541c46 (PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set) d

Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

2018-12-31 Thread Sinan Kaya
On Tue, Jan 1, 2019 at 12:42 AM Pierre-Louis Bossart wrote: > > > On 12/31/18 2:35 PM, Sinan Kaya wrote: > > On Mon, Dec 31, 2018 at 11:29 PM Pierre-Louis Bossart > > wrote: > >> > >> On 12/31/18 1:35 PM, Sinan Kaya wrote: > >>> On Mon, Dec 31, 2018 at 10:30 PM Mark Brown wrote: > On Mon, D

Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

2018-12-31 Thread Pierre-Louis Bossart
On 12/31/18 2:35 PM, Sinan Kaya wrote: On Mon, Dec 31, 2018 at 11:29 PM Pierre-Louis Bossart wrote: On 12/31/18 1:35 PM, Sinan Kaya wrote: On Mon, Dec 31, 2018 at 10:30 PM Mark Brown wrote: On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote: On Mon, Dec 31, 2018 at 8:47 PM Mark B

Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

2018-12-31 Thread Sinan Kaya
On Mon, Dec 31, 2018 at 11:29 PM Pierre-Louis Bossart wrote: > > > On 12/31/18 1:35 PM, Sinan Kaya wrote: > > On Mon, Dec 31, 2018 at 10:30 PM Mark Brown wrote: > >> On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote: > >>> On Mon, Dec 31, 2018 at 8:47 PM Mark Brown wrote: > I don't

Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

2018-12-31 Thread Pierre-Louis Bossart
On 12/31/18 1:35 PM, Sinan Kaya wrote: On Mon, Dec 31, 2018 at 10:30 PM Mark Brown wrote: On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote: On Mon, Dec 31, 2018 at 8:47 PM Mark Brown wrote: I don't have the cover letter or anything for this series, what's going on with dependenci

Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

2018-12-31 Thread Sinan Kaya
On Mon, Dec 31, 2018 at 10:30 PM Mark Brown wrote: > > On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote: > > On Mon, Dec 31, 2018 at 8:47 PM Mark Brown wrote: > > > > I don't have the cover letter or anything for this series, what's going > > > on with dependencies? > > > Here is the ex

Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

2018-12-31 Thread Mark Brown
On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote: > On Mon, Dec 31, 2018 at 8:47 PM Mark Brown wrote: > > I don't have the cover letter or anything for this series, what's going > > on with dependencies? > Here is the executive summary: > I have a changeset that separates ACPI from PC

Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

2018-12-31 Thread Sinan Kaya
On Mon, Dec 31, 2018 at 8:47 PM Mark Brown wrote: > > On Sun, Dec 30, 2018 at 07:56:09PM +, Sinan Kaya wrote: > > Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on > > CONFIG_PCI set but this is not specified anywhere. > > I don't have the cover letter or anything for thi

Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

2018-12-31 Thread Mark Brown
On Sun, Dec 30, 2018 at 07:56:09PM +, Sinan Kaya wrote: > Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on > CONFIG_PCI set but this is not specified anywhere. I don't have the cover letter or anything for this series, what's going on with dependencies? signature.asc D

[PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit

2018-12-30 Thread Sinan Kaya
Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on CONFIG_PCI set but this is not specified anywhere. Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") Signed-off-by: Sinan Kaya --- sound/soc/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+)