Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2

2017-01-10 Thread Boris Brezillon
On Mon, 09 Jan 2017 19:14:43 -0800 Stefan Agner wrote: > >> > >> > > >> > But, while reviewing your patch I realized this was actually unneeded > >> > (see the explanation in my previous review). > >> > > >> > > > >> > > Now it depends on cstate.enabled flag. > >> > > > >> > > So we end up wi

Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2

2017-01-09 Thread Stefan Agner
Hi Lukasz, Sry for the delay, I was traveling and had no access to hardware... On 2017-01-05 01:53, Boris Brezillon wrote: > On Thu, 5 Jan 2017 10:35:05 +0100 > Lukasz Majewski wrote: > >> On Thu, 5 Jan 2017 10:19:35 +0100 >> Boris Brezillon wrote: >> >> > On Thu, 5 Jan 2017 10:03:47 +0100 >>

Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2

2017-01-07 Thread Lukasz Majewski
Hi Stefan, > On Thu, 5 Jan 2017 10:03:47 +0100 > Lukasz Majewski wrote: > > > On Thu, 5 Jan 2017 09:50:35 +0100 > > Boris Brezillon wrote: > > > > > On Thu, 5 Jan 2017 00:36:50 +0100 > > > Lukasz Majewski wrote: > > > > > > > This commit provides apply() callback implementation for i.MX's

Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2

2017-01-05 Thread Boris Brezillon
On Thu, 5 Jan 2017 23:15:06 +0200 Andy Shevchenko wrote: > On Thu, Jan 5, 2017 at 11:19 AM, Boris Brezillon > wrote: > > On Thu, 5 Jan 2017 10:03:47 +0100 > > Lukasz Majewski wrote: > >> > /* > >> > * Wait for a free FIFO slot if the PWM is already > >> > enabled, and

Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2

2017-01-05 Thread Andy Shevchenko
On Thu, Jan 5, 2017 at 11:19 AM, Boris Brezillon wrote: > On Thu, 5 Jan 2017 10:03:47 +0100 > Lukasz Majewski wrote: >> > /* >> > * Wait for a free FIFO slot if the PWM is already >> > enabled, and >> > * flush the FIFO if the PWM was disabled and is >> > abo

Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2

2017-01-05 Thread Boris Brezillon
On Thu, 5 Jan 2017 10:35:05 +0100 Lukasz Majewski wrote: > On Thu, 5 Jan 2017 10:19:35 +0100 > Boris Brezillon wrote: > > > On Thu, 5 Jan 2017 10:03:47 +0100 > > Lukasz Majewski wrote: > > > > > On Thu, 5 Jan 2017 09:50:35 +0100 > > > Boris Brezillon wrote: > > > > > > > On Thu, 5 Jan

Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2

2017-01-05 Thread Lukasz Majewski
On Thu, 5 Jan 2017 10:19:35 +0100 Boris Brezillon wrote: > On Thu, 5 Jan 2017 10:03:47 +0100 > Lukasz Majewski wrote: > > > On Thu, 5 Jan 2017 09:50:35 +0100 > > Boris Brezillon wrote: > > > > > On Thu, 5 Jan 2017 00:36:50 +0100 > > > Lukasz Majewski wrote: > > > > > > > This commit prov

Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2

2017-01-05 Thread Boris Brezillon
On Thu, 5 Jan 2017 10:03:47 +0100 Lukasz Majewski wrote: > On Thu, 5 Jan 2017 09:50:35 +0100 > Boris Brezillon wrote: > > > On Thu, 5 Jan 2017 00:36:50 +0100 > > Lukasz Majewski wrote: > > > > > This commit provides apply() callback implementation for i.MX's > > > PWMv2. > > > > > > Sugge

Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2

2017-01-05 Thread Lukasz Majewski
On Thu, 5 Jan 2017 09:50:35 +0100 Boris Brezillon wrote: > On Thu, 5 Jan 2017 00:36:50 +0100 > Lukasz Majewski wrote: > > > This commit provides apply() callback implementation for i.MX's > > PWMv2. > > > > Suggested-by: Stefan Agner > > Suggested-by: Boris Brezillon > > Signed-off-by: Luka

Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2

2017-01-05 Thread Boris Brezillon
On Thu, 5 Jan 2017 00:36:50 +0100 Lukasz Majewski wrote: > This commit provides apply() callback implementation for i.MX's PWMv2. > > Suggested-by: Stefan Agner > Suggested-by: Boris Brezillon > Signed-off-by: Lukasz Majewski > Reviewed-by: Boris Brezillon > --- > Changes for v4: > - Avoid

[PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2

2017-01-04 Thread Lukasz Majewski
This commit provides apply() callback implementation for i.MX's PWMv2. Suggested-by: Stefan Agner Suggested-by: Boris Brezillon Signed-off-by: Lukasz Majewski Reviewed-by: Boris Brezillon --- Changes for v4: - Avoid recalculation of PWM parameters when disabling PWM signal - Unconditionally ca