Re: [PATCH v4 05/10] IB/isert: Replace semaphore sem with completion

2016-11-18 Thread Binoy Jayan
Hi Arnd, On 18 November 2016 at 14:28, Arnd Bergmann wrote: > On Friday, November 18, 2016 12:27:32 PM CET Binoy Jayan wrote: >> Hi Sagi, > I think you are right. This is behavior is actuallly documented in > Documentation/scheduler/completion.txt: Thanking for having a look. > However, this i

Re: [PATCH v4 05/10] IB/isert: Replace semaphore sem with completion

2016-11-18 Thread Arnd Bergmann
On Friday, November 18, 2016 12:27:32 PM CET Binoy Jayan wrote: > Hi Sagi, > > On 31 October 2016 at 02:42, Sagi Grimberg wrote: > >> The semaphore 'sem' in isert_device is used as completion, so convert > >> it to struct completion. Semaphores are going away in the future. > > > > > > Umm, this

Re: [PATCH v4 05/10] IB/isert: Replace semaphore sem with completion

2016-11-17 Thread Binoy Jayan
Hi Sagi, On 31 October 2016 at 02:42, Sagi Grimberg wrote: >> The semaphore 'sem' in isert_device is used as completion, so convert >> it to struct completion. Semaphores are going away in the future. > > > Umm, this is 100% *not* true. np->sem is designed as a counting to > sync the iscsi login

Re: [PATCH v4 05/10] IB/isert: Replace semaphore sem with completion

2016-10-30 Thread Sagi Grimberg
The semaphore 'sem' in isert_device is used as completion, so convert it to struct completion. Semaphores are going away in the future. Umm, this is 100% *not* true. np->sem is designed as a counting to sync the iscsi login thread with the connect requests coming from the initiators. So this is

[PATCH v4 05/10] IB/isert: Replace semaphore sem with completion

2016-10-27 Thread Binoy Jayan
The semaphore 'sem' in isert_device is used as completion, so convert it to struct completion. Semaphores are going away in the future. Signed-off-by: Binoy Jayan --- drivers/infiniband/ulp/isert/ib_isert.c | 6 +++--- drivers/infiniband/ulp/isert/ib_isert.h | 3 ++- 2 files changed, 5 insertion