Re: [PATCH v4 00/36] Large pages in the page cache

2020-05-28 Thread William Kucharski
Except for [PATCH v4 36/36], which I can't approve for obvious reasons: Reviewed-by: William Kucharski

Re: [PATCH v4 00/36] Large pages in the page cache

2020-05-25 Thread Matthew Wilcox
On Tue, May 26, 2020 at 09:07:51AM +1000, Dave Chinner wrote: > On Thu, May 21, 2020 at 08:05:53PM -0700, Matthew Wilcox wrote: > > On Fri, May 22, 2020 at 12:57:51PM +1000, Dave Chinner wrote: > > > Again, why is this dependent on THP? We can allocate compound pages > > > without using THP, so why

Re: [PATCH v4 00/36] Large pages in the page cache

2020-05-25 Thread Dave Chinner
On Thu, May 21, 2020 at 08:05:53PM -0700, Matthew Wilcox wrote: > On Fri, May 22, 2020 at 12:57:51PM +1000, Dave Chinner wrote: > > On Thu, May 21, 2020 at 05:04:11PM -0700, Matthew Wilcox wrote: > > > On Fri, May 22, 2020 at 08:49:06AM +1000, Dave Chinner wrote: > > > > Ok, so the main issue I hav

Re: [PATCH v4 00/36] Large pages in the page cache

2020-05-21 Thread Matthew Wilcox
On Fri, May 22, 2020 at 12:57:51PM +1000, Dave Chinner wrote: > On Thu, May 21, 2020 at 05:04:11PM -0700, Matthew Wilcox wrote: > > On Fri, May 22, 2020 at 08:49:06AM +1000, Dave Chinner wrote: > > > Ok, so the main issue I have with the filesystem/iomap side of > > > things is that it appears to b

Re: [PATCH v4 00/36] Large pages in the page cache

2020-05-21 Thread Dave Chinner
On Thu, May 21, 2020 at 05:04:11PM -0700, Matthew Wilcox wrote: > On Fri, May 22, 2020 at 08:49:06AM +1000, Dave Chinner wrote: > > Ok, so the main issue I have with the filesystem/iomap side of > > things is that it appears to be adding "transparent huge page" > > awareness to the filesysetm code,

Re: [PATCH v4 00/36] Large pages in the page cache

2020-05-21 Thread Matthew Wilcox
On Fri, May 22, 2020 at 08:49:06AM +1000, Dave Chinner wrote: > Ok, so the main issue I have with the filesystem/iomap side of > things is that it appears to be adding "transparent huge page" > awareness to the filesysetm code, not "large page support". > > For people that aren't aware of the diff

Re: [PATCH v4 00/36] Large pages in the page cache

2020-05-21 Thread Dave Chinner
On Fri, May 15, 2020 at 06:16:20AM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > This patch set does not pass xfstests. Test at your own risk. It is > based on the readahead rewrite which is in Andrew's tree. I've fixed a > lot of issues in the last two weeks, but generic/

[PATCH v4 00/36] Large pages in the page cache

2020-05-15 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" This patch set does not pass xfstests. Test at your own risk. It is based on the readahead rewrite which is in Andrew's tree. I've fixed a lot of issues in the last two weeks, but generic/013 will still crash it. The primary idea here is that a large part of th