Re: [PATCH v4 00/11] simplify block layer based on immutable biovecs

2015-06-03 Thread Ming Lin
On Wed, Jun 3, 2015 at 6:28 AM, Jeff Moyer wrote: > Christoph Hellwig writes: > >> On Sun, May 31, 2015 at 11:15:09PM -0700, Ming Lin wrote: >>> > Except for that these changes looks good, and the previous version >>> > passed my tests fine, so with some benchmarks you'ĺl have my ACK. >>> >>> Can

Re: [PATCH v4 00/11] simplify block layer based on immutable biovecs

2015-06-03 Thread Jeff Moyer
Christoph Hellwig writes: > On Sun, May 31, 2015 at 11:15:09PM -0700, Ming Lin wrote: >> > Except for that these changes looks good, and the previous version >> > passed my tests fine, so with some benchmarks you'ĺl have my ACK. >> >> Can I have your ACK with these numbers? >> https://lkml.org/l

Re: [PATCH v4 00/11] simplify block layer based on immutable biovecs

2015-06-02 Thread Christoph Hellwig
On Sun, May 31, 2015 at 11:15:09PM -0700, Ming Lin wrote: > > Except for that these changes looks good, and the previous version > > passed my tests fine, so with some benchmarks you'ĺl have my ACK. > > Can I have your ACK with these numbers? > https://lkml.org/lkml/2015/6/1/38 Looks good to me.

Re: [PATCH v4 00/11] simplify block layer based on immutable biovecs

2015-05-31 Thread Ming Lin
On Sat, May 23, 2015 at 7:15 AM, Christoph Hellwig wrote: > On Fri, May 22, 2015 at 11:18:32AM -0700, Ming Lin wrote: >> This will bring not only performance improvements, but also a great amount >> of reduction in code complexity all over the block layer. Performance gain >> is possible due to th

Re: [PATCH v4 00/11] simplify block layer based on immutable biovecs

2015-05-28 Thread Ming Lin
On Mon, May 25, 2015 at 6:51 AM, Christoph Hellwig wrote: > On Sun, May 24, 2015 at 12:37:32AM -0700, Ming Lin wrote: >> > Except for that these changes looks good, and the previous version >> > passed my tests fine, so with some benchmarks you'ĺl have my ACK. >> >> I'll test it on a 2 sockets ser

Re: [PATCH v4 00/11] simplify block layer based on immutable biovecs

2015-05-25 Thread Christoph Hellwig
On Sun, May 24, 2015 at 12:37:32AM -0700, Ming Lin wrote: > > Except for that these changes looks good, and the previous version > > passed my tests fine, so with some benchmarks you'ĺl have my ACK. > > I'll test it on a 2 sockets server with 10 NVMe drives on Monday. > I'm going to run fio tests:

Re: [PATCH v4 00/11] simplify block layer based on immutable biovecs

2015-05-24 Thread Ming Lin
On Sat, May 23, 2015 at 7:15 AM, Christoph Hellwig wrote: > On Fri, May 22, 2015 at 11:18:32AM -0700, Ming Lin wrote: >> This will bring not only performance improvements, but also a great amount >> of reduction in code complexity all over the block layer. Performance gain >> is possible due to th

Re: [PATCH v4 00/11] simplify block layer based on immutable biovecs

2015-05-23 Thread Christoph Hellwig
On Fri, May 22, 2015 at 11:18:32AM -0700, Ming Lin wrote: > This will bring not only performance improvements, but also a great amount > of reduction in code complexity all over the block layer. Performance gain > is possible due to the fact that bio_add_page() does not have to check > unnecesary c

[PATCH v4 00/11] simplify block layer based on immutable biovecs

2015-05-22 Thread Ming Lin
v4: - rebase on top of 4.1-rc4 - use BIO_POOL_SIZE instead of number 4 for bioset_create() - call blk_queue_split() in blk_mq_make_request() - call blk_queue_split() in zram_make_request() - add patch "block: remove bio_get_nr_vecs()" - remove split code in blkdev_issue_discard() - dr