Re: [PATCH v4 0/9] uprobes: misc cleanups/simplifications

2024-08-02 Thread Adrian Hunter
On 2/08/24 14:02, Adrian Hunter wrote: > On 2/08/24 12:25, Peter Zijlstra wrote: >> On Thu, Aug 01, 2024 at 02:13:41PM -0700, Andrii Nakryiko wrote: >> >>> Ok, this bisected to: >>> >>> 675ad74989c2 ("perf/core: Add aux_pause, aux_resume, aux_start_paused") >> >> Adrian, there are at least two obvi

Re: [PATCH v4 0/9] uprobes: misc cleanups/simplifications

2024-08-02 Thread Adrian Hunter
On 2/08/24 12:25, Peter Zijlstra wrote: > On Thu, Aug 01, 2024 at 02:13:41PM -0700, Andrii Nakryiko wrote: > >> Ok, this bisected to: >> >> 675ad74989c2 ("perf/core: Add aux_pause, aux_resume, aux_start_paused") > > Adrian, there are at least two obvious bugs there: > > - aux_action was key's o

Re: [PATCH v4 0/9] uprobes: misc cleanups/simplifications

2024-08-02 Thread Peter Zijlstra
On Thu, Aug 01, 2024 at 02:13:41PM -0700, Andrii Nakryiko wrote: > Ok, this bisected to: > > 675ad74989c2 ("perf/core: Add aux_pause, aux_resume, aux_start_paused") Adrian, there are at least two obvious bugs there: - aux_action was key's off of PERF_PMU_CAP_AUX_OUTPUT, which is not right,

Re: [PATCH v4 0/9] uprobes: misc cleanups/simplifications

2024-08-02 Thread Peter Zijlstra
On Thu, Aug 01, 2024 at 02:13:41PM -0700, Andrii Nakryiko wrote: > On Thu, Aug 1, 2024 at 11:58 AM Andrii Nakryiko > wrote: > > > > + bpf > > > > On Thu, Aug 1, 2024 at 6:36 AM Peter Zijlstra wrote: > > > > > > On Thu, Aug 01, 2024 at 03:26:38PM +0200, Oleg Nesterov wrote: > > > > (Andrii, I'll t

Re: [PATCH v4 0/9] uprobes: misc cleanups/simplifications

2024-08-01 Thread Andrii Nakryiko
On Thu, Aug 1, 2024 at 11:58 AM Andrii Nakryiko wrote: > > + bpf > > On Thu, Aug 1, 2024 at 6:36 AM Peter Zijlstra wrote: > > > > On Thu, Aug 01, 2024 at 03:26:38PM +0200, Oleg Nesterov wrote: > > > (Andrii, I'll try to look at your new series on Weekend). > > > > OK, I dropped all your previous

Re: [PATCH v4 0/9] uprobes: misc cleanups/simplifications

2024-08-01 Thread Andrii Nakryiko
+ bpf On Thu, Aug 1, 2024 at 6:36 AM Peter Zijlstra wrote: > > On Thu, Aug 01, 2024 at 03:26:38PM +0200, Oleg Nesterov wrote: > > (Andrii, I'll try to look at your new series on Weekend). > > OK, I dropped all your previous patches and stuffed these in. > > They should all be visible in queue/per

Re: [PATCH v4 0/9] uprobes: misc cleanups/simplifications

2024-08-01 Thread Peter Zijlstra
On Thu, Aug 01, 2024 at 03:26:38PM +0200, Oleg Nesterov wrote: > (Andrii, I'll try to look at your new series on Weekend). OK, I dropped all your previous patches and stuffed these in. They should all be visible in queue/perf/core, and provided the robot doesn't scream, I'll push them into tip/pe

[PATCH v4 0/9] uprobes: misc cleanups/simplifications

2024-08-01 Thread Oleg Nesterov
(Andrii, I'll try to look at your new series on Weekend). Changes: - added the acks I got from Andrii, Masami, and Jiri - new 4/9 patch from Jiri, fixes the unrelated bug in bpf_testmod - adapt tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c to the API chan