Hi Markus,
What are your thoughts on how we should proceed with this patchset? You raised
a few concerns in December - however, I'm
not sure what further changes might be needed, if any. IMO this could be merged
as it stands.
Regarding compatibility concerns: patchset v4 does not modify the be
Hi Markus,
On 06/12/2018 3:47 pm, Markus F.X.J. Oberhumer wrote:> Request 3 - add lzo-rle;
*NOT* acked by me
>
> [PATCH 6/8] lib/lzo: implement run-length encoding
> [PATCH 7/8] lib/lzo: separate lzo-rle from lzo
> [PATCH 8/8] zram: default to lzo-rle instead of lzo
>
> It (1) s
Markus,
> Request 2 - add COPY16; *NOT* acked by me
>
> [PATCH 2/8] lib/lzo: clean-up by introducing COPY16
>
> is still not correct because of possible overlapping copies. I'll
> address this on the weekend.
Can you give a syndrome as to why
{
COPY8(op, ip);
COPY8(op+8,ip+8)
On 2018-11-30 15:26, Dave Rodgman wrote:
> This patch series introduces performance improvements for lzo.
>
> The previous version of this patchset is here:
> https://lkml.org/lkml/2018/11/30/807
>
> This version of the patchset fixes a maybe-used-uninitialized warning
> (although the previous ve
On (12/05/18 09:50), Dave Rodgman wrote:
> > lib/lzo/lzo1x_compress.c: In function ‘lzo1x_1_do_compress’:
> > lib/lzo/lzo1x_compress.c:239:14: warning: ‘m_pos’ may be used uninitialized
> > in this function [-Wmaybe-uninitialized]
> > 239 | m_off = ip - m_pos;
> >
> > Care to take a look? (coul
On 05/12/2018 7:30 am, Sergey Senozhatsky wrote:
> Hi Dave,
>
> Notices this warning today:
>
> lib/lzo/lzo1x_compress.c: In function ‘lzo1x_1_do_compress’:
> lib/lzo/lzo1x_compress.c:239:14: warning: ‘m_pos’ may be used uninitialized
> in this function [-Wmaybe-uninitialized]
> 239 | m_off =
On (11/30/18 14:26), Dave Rodgman wrote:
>
> This patch series introduces performance improvements for lzo.
>
> The previous version of this patchset is here:
> https://lkml.org/lkml/2018/11/30/807
>
> This version of the patchset fixes a maybe-used-uninitialized warning
> (although the previous
This patch series introduces performance improvements for lzo.
The previous version of this patchset is here:
https://lkml.org/lkml/2018/11/30/807
This version of the patchset fixes a maybe-used-uninitialized warning
(although the previous version was still safe).
Dave
8 matches
Mail list logo
