Re: [PATCH v4 0/3] Fix find_first_zero_bit() usage

2017-12-15 Thread Lorenzo Pieralisi
On Thu, Dec 14, 2017 at 05:21:38PM -0600, Bjorn Helgaas wrote: > On Thu, Dec 14, 2017 at 01:47:07PM +, Lorenzo Pieralisi wrote: > > On Thu, Dec 14, 2017 at 02:32:30PM +0100, Niklas Cassel wrote: > > > On Wed, Dec 13, 2017 at 03:59:25PM -0600, Bjorn Helgaas wrote: > > > > On Tue, Dec 12, 2017 at

Re: [PATCH v4 0/3] Fix find_first_zero_bit() usage

2017-12-14 Thread Bjorn Helgaas
On Thu, Dec 14, 2017 at 01:47:07PM +, Lorenzo Pieralisi wrote: > On Thu, Dec 14, 2017 at 02:32:30PM +0100, Niklas Cassel wrote: > > On Wed, Dec 13, 2017 at 03:59:25PM -0600, Bjorn Helgaas wrote: > > > On Tue, Dec 12, 2017 at 03:16:31PM +0100, Niklas Cassel wrote: > > > > find_first_zero_bit()'s

Re: [PATCH v4 0/3] Fix find_first_zero_bit() usage

2017-12-14 Thread Lorenzo Pieralisi
On Thu, Dec 14, 2017 at 02:32:30PM +0100, Niklas Cassel wrote: > On Wed, Dec 13, 2017 at 03:59:25PM -0600, Bjorn Helgaas wrote: > > On Tue, Dec 12, 2017 at 03:16:31PM +0100, Niklas Cassel wrote: > > > find_first_zero_bit()'s parameter 'size' is defined in bits, > > > not in bytes. > > > > > > Call

Re: [PATCH v4 0/3] Fix find_first_zero_bit() usage

2017-12-14 Thread Niklas Cassel
On Wed, Dec 13, 2017 at 03:59:25PM -0600, Bjorn Helgaas wrote: > On Tue, Dec 12, 2017 at 03:16:31PM +0100, Niklas Cassel wrote: > > find_first_zero_bit()'s parameter 'size' is defined in bits, > > not in bytes. > > > > Calling find_first_zero_bit() with the wrong size unit > > will lead to insidio

Re: [PATCH v4 0/3] Fix find_first_zero_bit() usage

2017-12-14 Thread Kishon Vijay Abraham I
Hi Lorenzo, On Thursday 14 December 2017 04:21 PM, Lorenzo Pieralisi wrote: > Hi Kishon, > > On Tue, Dec 12, 2017 at 03:16:31PM +0100, Niklas Cassel wrote: >> find_first_zero_bit()'s parameter 'size' is defined in bits, >> not in bytes. >> >> Calling find_first_zero_bit() with the wrong size unit

Re: [PATCH v4 0/3] Fix find_first_zero_bit() usage

2017-12-14 Thread Lorenzo Pieralisi
Hi Kishon, On Tue, Dec 12, 2017 at 03:16:31PM +0100, Niklas Cassel wrote: > find_first_zero_bit()'s parameter 'size' is defined in bits, > not in bytes. > > Calling find_first_zero_bit() with the wrong size unit > will lead to insidious bugs. > > Fix all uses of find_first_zero_bit() called with

Re: [PATCH v4 0/3] Fix find_first_zero_bit() usage

2017-12-13 Thread Bjorn Helgaas
On Tue, Dec 12, 2017 at 03:16:31PM +0100, Niklas Cassel wrote: > find_first_zero_bit()'s parameter 'size' is defined in bits, > not in bytes. > > Calling find_first_zero_bit() with the wrong size unit > will lead to insidious bugs. > > Fix all uses of find_first_zero_bit() called with > sizeof()

RE: [PATCH v4 0/3] Fix find_first_zero_bit() usage

2017-12-12 Thread David Laight
From: Lorenzo Pieralisi > Sent: 12 December 2017 15:24 > > On Tue, Dec 12, 2017 at 02:33:52PM +, David Laight wrote: > > From: Niklas Cassel > > > find_first_zero_bit()'s parameter 'size' is defined in bits, > > > not in bytes. > > > > > > Calling find_first_zero_bit() with the wrong size unit

Re: [PATCH v4 0/3] Fix find_first_zero_bit() usage

2017-12-12 Thread Lorenzo Pieralisi
On Tue, Dec 12, 2017 at 02:33:52PM +, David Laight wrote: > From: Niklas Cassel > > find_first_zero_bit()'s parameter 'size' is defined in bits, > > not in bytes. > > > > Calling find_first_zero_bit() with the wrong size unit > > will lead to insidious bugs. > > > > Fix all uses of find_first

RE: [PATCH v4 0/3] Fix find_first_zero_bit() usage

2017-12-12 Thread David Laight
From: Niklas Cassel > find_first_zero_bit()'s parameter 'size' is defined in bits, > not in bytes. > > Calling find_first_zero_bit() with the wrong size unit > will lead to insidious bugs. > > Fix all uses of find_first_zero_bit() called with > sizeof() as size argument in drivers/pci. ... Isn't

[PATCH v4 0/3] Fix find_first_zero_bit() usage

2017-12-12 Thread Niklas Cassel
find_first_zero_bit()'s parameter 'size' is defined in bits, not in bytes. Calling find_first_zero_bit() with the wrong size unit will lead to insidious bugs. Fix all uses of find_first_zero_bit() called with sizeof() as size argument in drivers/pci. Also had to fix broken error handling in pci_