Re: [PATCH v4] tty: add missing rcu_read_lock for task_pgrp

2015-07-20 Thread Oleg Nesterov
On 07/20, Jiri Slaby wrote: > > CC Oleg > > On 07/13/2015, 12:51 AM, Patrick Donnelly wrote: > > task_pgrp requires an rcu or tasklist lock to be obtained if the returned > > pid > > is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the > > duration of use. Look like, this chang

Re: [PATCH v4] tty: add missing rcu_read_lock for task_pgrp

2015-07-20 Thread Jiri Slaby
CC Oleg On 07/13/2015, 12:51 AM, Patrick Donnelly wrote: > task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid > is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the > duration of use. > > Signed-off-by: Patrick Donnelly > --- > drivers/tty/n_tty.c

Re: [PATCH v4] tty: add missing rcu_read_lock for task_pgrp

2015-07-12 Thread Peter Hurley
On 07/12/2015 06:51 PM, Patrick Donnelly wrote: > task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid > is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the > duration of use. Reviewed-by: Peter Hurley -- To unsubscribe from this list: send the line "

[PATCH v4] tty: add missing rcu_read_lock for task_pgrp

2015-07-12 Thread Patrick Donnelly
task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the duration of use. Signed-off-by: Patrick Donnelly --- drivers/tty/n_tty.c | 15 --- drivers/tty/tty_io.c | 17 - 2 fil