Missatge de Enric Balletbo i Serra del
dia dj., 29 d’ag. 2019 a les 15:44:
>
> Hi Tzung-Bi,
>
> On 29/8/19 6:19, Tzung-Bi Shih wrote:
> > Hi Enric and Raul,
> >
> > Do you have any further concerns on this patch?
>
> This patch will conflict with [2] which hopefully will be merged on next merge
>
Hi Tzung-Bi,
On 29/8/19 6:19, Tzung-Bi Shih wrote:
> Hi Enric and Raul,
>
> Do you have any further concerns on this patch?
This patch will conflict with [2] which hopefully will be merged on next merge
window through Lee's tree. As this patch is only changing the doc I'm willing to
wait after [
On Thu, Aug 01, 2019 at 03:30:53PM +0200, Enric Balletbo i Serra wrote:
> Got it. I don't think this is a "kernel" way to do it. Also, I don't see a big
> value on doing this.
Code generation sounds great, but it makes finding and looking at the
source file difficult unless you have a build. It
Hi Tzung-Bi,
On 1/8/19 15:04, Tzung-Bi Shih wrote:
> On Thu, Aug 1, 2019 at 6:59 PM Enric Balletbo i Serra
> wrote:
>>
>> Hi Tzung-Bi
>>
>> On 30/7/19 16:07, Tzung-Bi Shih wrote:
>>> Hi Enric,
>>>
>>> I found it is error-prone to replace the EC_CMDS after updated.
>>> Perhaps, we should introduce
On Thu, Aug 1, 2019 at 6:59 PM Enric Balletbo i Serra
wrote:
>
> Hi Tzung-Bi
>
> On 30/7/19 16:07, Tzung-Bi Shih wrote:
> > Hi Enric,
> >
> > I found it is error-prone to replace the EC_CMDS after updated.
> > Perhaps, we should introduce an intermediate file "cros_ec_trace.inc".
>
> I am not sure
Hi Tzung-Bi
On 30/7/19 16:07, Tzung-Bi Shih wrote:
> Hi Enric,
>
> I found it is error-prone to replace the EC_CMDS after updated.
> Perhaps, we should introduce an intermediate file "cros_ec_trace.inc".
I am not sure I get you here, a .inc? could you explain a bit more?
Thanks,
~ Enric
> The
Hi Enric,
I found it is error-prone to replace the EC_CMDS after updated.
Perhaps, we should introduce an intermediate file "cros_ec_trace.inc".
The generating script replaces whole ".inc" file every time and the
cros_ec_trace.c includes the "cros_ec_trace.inc".
If this proposal makes sense to yo
The original script generates unneeded ", \" on the last line which
results in compile error if one would forget to remove them. Update the
script to not generate ", \" on the last line. Also add a define guard
for EC_CMDS.
Signed-off-by: Tzung-Bi Shih
---
Changes from v1:
- simpler awk code
Ch
8 matches
Mail list logo
