Re: [PATCH v4] phy: samsung: Use readl_poll_timeout function

2020-07-20 Thread Anand Moon
Hi Krzysztof, On Mon, 20 Jul 2020 at 13:20, Krzysztof Kozlowski wrote: > > On Mon, Jul 13, 2020 at 07:42:43AM +, Anand Moon wrote: > > Instead of a busy waiting while loop using udelay > > use readl_poll_timeout function to check the condition > > is met or timeout occurs in crport_handshake

Re: [PATCH v4] phy: samsung: Use readl_poll_timeout function

2020-07-20 Thread Krzysztof Kozlowski
On Mon, Jul 13, 2020 at 07:42:43AM +, Anand Moon wrote: > Instead of a busy waiting while loop using udelay > use readl_poll_timeout function to check the condition > is met or timeout occurs in crport_handshake function. > readl_poll_timeout is called in non atomic context so > it safe to slee

Re: [PATCH v4] phy: samsung: Use readl_poll_timeout function

2020-07-15 Thread Anand Moon
Hi Vinod, On Thu, 16 Jul 2020 at 11:20, Vinod Koul wrote: > > On 13-07-20, 07:42, Anand Moon wrote: > > Instead of a busy waiting while loop using udelay > > use readl_poll_timeout function to check the condition > > is met or timeout occurs in crport_handshake function. > > readl_poll_timeout is

Re: [PATCH v4] phy: samsung: Use readl_poll_timeout function

2020-07-15 Thread Vinod Koul
On 13-07-20, 07:42, Anand Moon wrote: > Instead of a busy waiting while loop using udelay > use readl_poll_timeout function to check the condition > is met or timeout occurs in crport_handshake function. > readl_poll_timeout is called in non atomic context so > it safe to sleep until the condition

[PATCH v4] phy: samsung: Use readl_poll_timeout function

2020-07-13 Thread Anand Moon
Instead of a busy waiting while loop using udelay use readl_poll_timeout function to check the condition is met or timeout occurs in crport_handshake function. readl_poll_timeout is called in non atomic context so it safe to sleep until the condition is met. Fixes: d8c80bb3b55b ("phy: exynos5-usbd