Re: [PATCH v4] perf annotate: Fix sample events lost in stdio mode

2021-03-15 Thread Yang Jihong
Hello, On 2021/3/13 11:06, Namhyung Kim wrote: On Sat, Mar 13, 2021 at 11:16 AM Yang Jihong wrote: In hist__find_annotations function, since different hist_entry may point to same symbol, we free notes->src to signal already processed this symbol in stdio mode; when annotate, entry will skip

Re: [PATCH v4] perf annotate: Fix sample events lost in stdio mode

2021-03-15 Thread Yang Jihong
Hi, On 2021/3/13 11:06, Namhyung Kim wrote: On Sat, Mar 13, 2021 at 11:16 AM Yang Jihong wrote: In hist__find_annotations function, since different hist_entry may point to same symbol, we free notes->src to signal already processed this symbol in stdio mode; when annotate, entry will skipped

Re: [PATCH v4] perf annotate: Fix sample events lost in stdio mode

2021-03-12 Thread Namhyung Kim
On Sat, Mar 13, 2021 at 11:16 AM Yang Jihong wrote: > > In hist__find_annotations function, since different hist_entry may point to > same > symbol, we free notes->src to signal already processed this symbol in stdio > mode; > when annotate, entry will skipped if notes->src is NULL to avoid repe

[PATCH v4] perf annotate: Fix sample events lost in stdio mode

2021-03-12 Thread Yang Jihong
In hist__find_annotations function, since different hist_entry may point to same symbol, we free notes->src to signal already processed this symbol in stdio mode; when annotate, entry will skipped if notes->src is NULL to avoid repeated output. However, there is a problem, for example, run the f